drm: apple: iomfb: fix framebuffer retirement on DCP 14.7 - #583
Open
a-ramses wants to merge 2 commits into
Open
Conversation
Member
|
Have you tested it with more than one plane active? |
chadmed
requested changes
Aug 28, 2026
chadmed
left a comment
chadmed
left a comment
Member
There was a problem hiding this comment.
Please split this into two commits: one to fix the struct layout, and a revert commit for the hack. Also please ensure you have tested this with multiple active surfaces (e.g. with KWIN_USE_OVERLAYS=1).
chadmed
requested changes
Aug 28, 2026
| u32 unkU32Ptr; | ||
| #endif | ||
| #if DCP_FW_VER >= DCP_FW_VERSION(14, 7, 0) | ||
| /* |
Member
There was a problem hiding this comment.
We don't need this comment, the commit message and preprocessor directives both make this very obvious. Please drop it.
a-ramses
force-pushed
the
draft/dcp-v14.7-fb-retirement
branch
from
August 28, 2026 17:53
f32b477 to
ec3a947
Compare
Author
Tested with No errors. |
Member
|
|
a-ramses
changed the title
Member
|
You need to change the commit line too :P |
DCP 14.7 expects its 0x234-byte extension before the pointer-null flags. Linux placed it after the flags, so DCP read the flags at the old offsets and rejected surface-clear requests. Move the extension before the pointer-null flags. Signed-off-by: a-ramses <abdicheramzi@gmail.com>
This reverts commit 47508c0. The DCP 14.7 request layout now matches the firmware, so surface-clear requests work and stale framebuffer references can be retired again. Signed-off-by: a-ramses <abdicheramzi@gmail.com>
a-ramses
force-pushed
the
draft/dcp-v14.7-fb-retirement
branch
from
August 29, 2026 13:01
ec3a947 to
cddf57e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix framebuffer retirement with DCP firmware ABI 14.7 by:
swapped_out_fbsretirement logic for ABI 14.7.Linux placed the null flags before the extension, so DCP did not process surface-clear requests. The workaround disabled framebuffer release for ABI 14.7.
Testing
Tested on T6030/M3 Pro: