[NinosMan]

Summary

Integration authors have no guidance on tests/teamcity.env: which test values are secrets, and how to supply each one so live tests run in TeamCity. This PR adds that guidance, and merges the two test-writing skills into one.

Changes

• New writing-tests skill. It replaces writing-unit-tests and writing-integration-tests.

  • SKILL.md routes to the right file.
  • unit-tests.md and integration-tests.md hold the previous content, moved with history kept.

• New "Running Live Tests in TeamCity" section in integration-tests.md. It covers:

  • what counts as a secret;
  • the tests/teamcity.env location and format;
  • plain values;
  • ah:customAuth:<field> for custom auth credentials;
  • ah:secret for other secrets;
  • platform OAuth tokens;
  • how to read the pull request comment.

  The Workflow section gains a step to add teamcity.env. The CI rows now say that live tests never run in GitHub Actions, and that the non-destructive ones run in TeamCity.

• References updated in both README tables and in building-integration, upgrading-sdk-v2 and reviewing-integration-prs. The review skill also gains a check that teamcity.env contains no plain secrets, and that each ah:customAuth field is declared in config.json.

Notes

• The section describes only what contributors need to write the file. It leaves out internal account, secret-store and build configuration details, because this repository is public.
• If you installed the old skills by symlinking writing-unit-tests or writing-integration-tests, re-link writing-tests instead.

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-29T02:41:06.033675Z	6aeb72a	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[github-actions]

Coverage — 4bcd3c6 (docs(skills): avoid promising credentials never appear in build logs) by @NinosMan

Total coverage: 100%

File	Stmts	Miss	Cover	Missing
src/autohive_integrations_sdk/__init__.py	2	0	100%
src/autohive_integrations_sdk/integration.py	390	0	100%

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6aeb72af66

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[TheRealAgentK]

Minor documentation finding (P3): avoid promising that credentials can never appear in build logs.

In skills/writing-tests/integration-tests.md, line 647 says: “The build never prints the values of credentials.” The current TeamCity runner forwards pytest output and failure tracebacks without credential redaction, so test assertions or provider errors could expose them.

Suggested wording: “The runner does not explicitly log resolved credentials. Tests must also avoid including secrets in output, assertion messages, or skip reasons.”

This is non-blocking; I found no merge-blocking issues in the reviewed changes.