Repository navigation
use enumeration options when enumerating the inner stream in BufferedRankedStream - #48
Merged
Merged
Conversation
|
coverage: 80.255% (-0.02%) from 80.271% — lucila/pass-enumerate-options-to-inner-stream into main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why? 🤔
Enumeration options should be passed to the inner streams.
BufferedRankedStreamwas not passing$optionwhen calling$this->inner->enumerate()All the other streams that contain inner streams already do this.
Also,
FilteredStreamwas usingandinstead of&&Testing Steps ✍️
Code review
You're it! 👑
Tag a random reviewer by adding
@Automattic/stream-buildersto the reviewers section, but mention them here for visibility as well.