Repository navigation
fix: release the xSolvBTC rename as minor, not major - #41
Merged
Merged
Conversation
The rename keeps the same contract, address and decimals and only corrects the label to match Solv's on-chain rebrand. No AvaProtocol repo reads Tokens["SolvBTC.BBN"]. Token lists treat a symbol change on an existing token as a minor-or-smaller change, and a rule that every issuer rebrand is a major release would hold back unrelated fixes. The catalog policy now says so: following an on-chain rename is a minor changeset that names the old key; removing a row or changing its address stays major. The pending release becomes 1.2.0 instead of 2.0.0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #40. With this merged, release PR #39 recalculates from 2.0.0 to 1.2.0.
Why minor
The only major changeset in #40 was renaming Ethereum
Tokens["SolvBTC.BBN"]toTokens.xSolvBTC. That was strict semver applied too literally:name()andsymbol().Tokens["SolvBTC.BBN"]. EigenLayer-AVS keeps its own copy of the whitelist, Studio's two hits are a Chainlink feed name and a test string, and ava-sdk-js and context-memory don't mention it.lookupTokenreturns ("WETH" → "WBNB") and shipped as minor.Changes
.changeset/rename-solvbtc-bbn-xsolvbtc.md: the bump goes frommajortominor. The changelog note still names the old key and the replacement.docs/TOKEN_CATALOG.md: following an issuer's on-chain rename is a minor changeset that names the old key. Removing a row or changing its address stays major.npx changeset statusreports a minor bump and no major. 137 tests pass.🤖 Generated with Claude Code