Skip to content

Document Testcontainers API version override - #2807

Merged
Akanksha Jain (jainakanksha-msft) merged 6 commits into
mainfrom
copilot/update-readme-testcontainers-guidance
Sep 24, 2026
Merged

Akanksha Jain (jainakanksha-msft) merged 6 commits into
mainfrom
copilot/update-readme-testcontainers-guidance

Conversation

Copilot AI commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Add a Testcontainers subsection under the DockerHub guidance.
  • Document how to pass --skipApiVersionCheck with the current .NET AzuriteBuilder API.
  • Document the equivalent Java GenericContainer.withCommand configuration.
  • Preserve Azurite host bindings and the Java container's -l /data persistence path.
  • Link to the official Testcontainers command/configuration documentation.

Validation

  • npx prettier --check README.md
  • git diff --check

Fixes #2432

Original prompt

Resolve Azure/Azurite issue #2432 with a focused README update. Under the Docker guidance, document how Testcontainers users pass --skipApiVersionCheck. Include concise confirmed examples for .NET AzuriteBuilder using WithCommand and Java GenericContainer command configuration, with appropriate official Testcontainers documentation links. Match existing README formatting, avoid unsupported claims, validate links and Prettier, and keep the change documentation-only. Include 'Fixes #2432' in the PR body.

Copilot AI lite review requested due to automatic review settings September 24, 2026 08:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Co-authored-by: jainakanksha-msft <181211853+jainakanksha-msft@users.noreply.github.com>
Copilot AI review requested due to automatic review settings September 24, 2026 08:40
Co-authored-by: jainakanksha-msft <181211853+jainakanksha-msft@users.noreply.github.com>
Co-authored-by: jainakanksha-msft <181211853+jainakanksha-msft@users.noreply.github.com>
Copilot AI changed the title [WIP] Update README with Testcontainers usage for Azurite Document Testcontainers command configuration for skipping Azurite API version checks Sep 24, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The .NET WithCommand example must include azurite as the first argument so the container starts correctly.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 Medium severity

Open (1)

Comment thread README.md
Copilot AI review requested due to automatic review settings September 24, 2026 08:44
@jainakanksha-msft Akanksha Jain (jainakanksha-msft) changed the title Document Testcontainers command configuration for skipping Azurite API version checks Document Testcontainers API version override Sep 24, 2026
@jainakanksha-msft
Akanksha Jain (jainakanksha-msft) marked this pull request as ready for review September 24, 2026 08:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Unresolved command, persistence, constructor, and PR-body issues remain.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 High severity · 1 Medium severity · 1 Low severity

Open (3)

Comment thread README.md
Comment thread README.md Outdated
@jainakanksha-msft

Copy link
Copy Markdown
Member

Copilot Please address all unresolved review feedback on this PR. Update the .NET Testcontainers sample so it uses the current image-taking AzuriteBuilder constructor, and make the overridden command executable by putting "azurite" first. Preserve the image's -l /data behavior unless there is a documented reason not to. Keep the Java example consistent. Validate the exact current Testcontainers API, run Prettier and git diff --check, commit the changes to this PR branch, then report the validation results. Do not merely edit the PR description.

…va example

Co-authored-by: jainakanksha-msft <181211853+jainakanksha-msft@users.noreply.github.com>
Copilot AI review requested due to automatic review settings September 24, 2026 10:31

Copilot AI commented Sep 24, 2026

Copy link
Copy Markdown
Contributor Author

Copilot Please address all unresolved review feedback on this PR. Update the .NET Testcontainers sample so it uses the current image-taking AzuriteBuilder constructor, and make the overridden comma...

Updated in ca2f9dc (see commit for exact hash pushed). Changes:

  • .NET sample now uses new AzuriteBuilder("mcr.microsoft.com/azure-storage/azurite:latest") instead of the obsolete parameterless constructor + WithImage.
  • I verified the current Testcontainers .NET source (AzuriteBuilder.Init() calls .WithEntrypoint("azurite") before setting the default command). Since the entrypoint is already azurite, adding "azurite" as the first WithCommand argument would pass it as a literal CLI argument to Azurite (duplicating the executable name) rather than making the command executable, so it's intentionally left out of the .NET sample — I added a note explaining this.
  • For Java's GenericContainer.withCommand, which replaces the image's entire default CMD (no separate entrypoint), "azurite" stays as the first argument, and I added "-l", "/data" to preserve the image's default persistence path.
  • Ran Prettier (npx prettier --check README.md) and git diff --check; both pass.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

Documentation-only changes are focused, low risk, and have no unresolved review issues.

Review effort: Lite
Findings: None

Resolved since last review (3)

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Add Fixes #2432 to the PR body and correct the Java documentation anchor.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 Low severity

Open (1)

Comment thread README.md

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

Documentation-only changes have no unresolved issues.

Review effort: Lite
Findings: None

Resolved since last review (1)

@jainakanksha-msft
Akanksha Jain (jainakanksha-msft) merged commit 1436cad into main Sep 24, 2026
47 checks passed
@jainakanksha-msft
Akanksha Jain (jainakanksha-msft) deleted the copilot/update-readme-testcontainers-guidance branch September 24, 2026 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot add --skipApiVersionCheck when using testcontainers

3 participants