Validate proposed Blob and Container lease IDs

[Copilot]

Azurite accepted malformed x-ms-proposed-lease-id values on Blob and Container acquire/change lease paths. Azure Storage rejects these with InvalidHeaderValue and accepts the documented GUID string formats, including X-format GUIDs.

• Lease ID validation
  • Added shared proposed lease ID validation for Azure-compatible GUID formats.
  • Applied validation to Blob and Container acquireLease and changeLease handlers.
  • Returns InvalidHeaderValue with HeaderName / HeaderValue details for malformed proposed lease IDs.

validateProposedLeaseId(options.proposedLeaseId, context.contextId);
validateProposedLeaseId(proposedLeaseId, context.contextId);

• Coverage

  • Added Blob and Container API tests for malformed acquire/change proposed lease IDs.
  • Preserved standard GUID behavior.
  • Added explicit X-format GUID acceptance coverage.
  • Added regression coverage rejecting an X-format value with an extra closing brace.

• Release notes

  • Added an Upcoming Release changelog entry for the Blob lease compatibility fix.

Original prompt

Fix Azure/Azurite issue #2367. Validate proposed lease IDs for Blob and Container acquire/change lease paths using Azure-compatible GUID formats and InvalidHeaderValue behavior. Reuse repository validation/error patterns. Cover all affected paths with malformed ID tests, retain valid standard GUID behavior, and explicitly test valid X-format GUID acceptance plus rejection of an X-format value with an extra closing brace. Be careful that the X-format regex has exactly the correct closing braces; a prior local review caught an extra-brace bug. Add Upcoming Release ChangeLog entry. Run focused blob/container tests, build, lint, diagnostics, and diff check. The validated local version touched BlobHandler.ts, ContainerHandler.ts, blob/utils/utils.ts, blob/container API tests, and ChangeLog.md. Include 'Fixes #2367' in the PR body.

[Copilot]

Copilot wasn't able to review any files in this pull request.

---

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Copilot review overview

🟡 Changes recommended

Accept uppercase 0X prefixes and add the requested focused tests and changelog entry.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 2

Open (2)

• Document externally visible validation changes in ChangeLog.md · New
• Add focused tests for malformed and valid lease ID formats · New

[Copilot]

Copilot review overview

🟡 Changes recommended

Fix invalid existing lease fixtures and prevent malformed-ID tests from contaminating subsequent tests.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 · 2

Open (3)

• Update lease fixtures to valid GUIDs · New
• Add focused tests for malformed and valid lease ID formats
• Document externally visible validation changes in ChangeLog.md

[Copilot]

Copilot review overview

🔵 Needs a closer look

Add coverage for braced and parenthesized GUID formats and the exact Fixes #2367 PR keyword.

Review effort: Lite
Findings: 1 · 2

Open (3)

• Update lease fixtures to valid GUIDs
• Add focused tests for malformed and valid lease ID formats
• Document externally visible validation changes in ChangeLog.md

[Akanksha Jain (jainakanksha-msft)]

Copilot Please address all remaining review feedback on this PR. At minimum: (1) replace every existing proposed-lease fixture using "abcdefg" in Block Blob and Append Blob tests with deterministic valid GUIDs so the full Blob suite remains compatible with the new validation; (2) add explicit positive coverage for braced and parenthesized GUID formats, while retaining standard and X-format coverage and the malformed extra-brace case; (3) verify whether Azure/.NET GUID X-format parsing accepts uppercase 0X prefixes and align implementation/tests if so; (4) confirm the Upcoming Release changelog entry and exact Fixes #2367 body keyword remain present. Run the focused tests, full npm run test:blob, build, lint, and git diff --check; commit to this PR branch and report exact results. Do not only update the PR body.

[Copilot]

Copilot review overview

🟢 Approval recommended

No unresolved blocking issues were identified, and the implementation and coverage align with the requested behavior.

Review effort: Lite
Findings: 1 · 2

Open (3)

• Update lease fixtures to valid GUIDs
• Add focused tests for malformed and valid lease ID formats
• Document externally visible validation changes in ChangeLog.md

[Copilot]

Copilot Please address all remaining review feedback on this PR. At minimum: (1) replace every existing proposed-lease fixture using "abcdefg" in Block Blob and Append Blob tests with deterministic...

Addressed in 2b13d09 and cleanup commit 785fc8e.

Results:

• Replaced all remaining "abcdefg" proposed-lease fixtures in Block Blob/Append Blob tests with deterministic valid GUIDs.
• Added Blob and Container acquire/change positive coverage for braced, parenthesized, X-format, and uppercase 0X X-format proposed lease IDs, while retaining malformed extra-brace coverage.
• Verified .NET Guid.TryParse accepts uppercase 0X prefixes and aligned the validator/tests.
• Confirmed the Upcoming Release changelog entry remains present and PR body contains Fixes #2367.
• Validation: focused lease tests 19 passing; npm run lint passed; npm run build passed; npm run test:blob passed with 626 passing, 3 pending; git diff --check passed; secret scan passed; final parallel validation passed with no review comments and 0 CodeQL alerts.

[Copilot]

Copilot review overview

🟢 Approval recommended

No unresolved review issues were identified, and all approval assessments are positive.

Review effort: Lite
Findings: 1 · 2

Open (3)

• Update lease fixtures to valid GUIDs
• Add focused tests for malformed and valid lease ID formats
• Document externally visible validation changes in ChangeLog.md

[Copilot]

Copilot review overview

🟢 Approval recommended

No unresolved blocking issues were identified in the reviewed changes.

Review effort: Lite
Findings: None

Resolved since last review (3)

• Update lease fixtures to valid GUIDs
• Add focused tests for malformed and valid lease ID formats
• Document externally visible validation changes in ChangeLog.md