Skip to content

[DurableTask.ServiceBus] Log messages dropped by MessageSender.SendAsync when they don't fit in the batch #1425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Bernd Verst (berndverst) merged 3 commits into from
Nov 4, 2026
Merged

[DurableTask.ServiceBus] Log messages dropped by MessageSender.SendAsync when they don't fit in the batch #1425

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
417fec5
Log messages dropped by MessageSender.SendAsync when they don't fit i…
davidemontanari Oct 22, 2026
745c131
Improved logging
davidemontanari Oct 22, 2026
7c7e053
Removed messageIds and fixed log message
davidemontanari Oct 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 27 additions & 5 deletions src/DurableTask.ServiceBus/Common/Abstraction/ServiceBusAbstraction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,10 @@ namespace DurableTask.ServiceBus.Common.Abstraction
{
using System;
using System.Collections.Generic;
using System.Diagnostics;
using System.Linq;
using System.Threading.Tasks;
using DurableTask.Core.Tracing;

/// <inheritdoc />
public class IMessageSession
Expand Down Expand Up @@ -330,15 +332,35 @@ public async Task SendAsync(Message message)
await sender.SendMessageAsync(message);
}

/// <summary>
/// Sends the messages in a single batch. Messages that do not fit in the batch are not sent and are traced as errors.
/// </summary>
public async Task SendAsync(IEnumerable<Message> messageList)
{
var batch = await sender.CreateMessageBatchAsync();
foreach (var message in messageList)
using (Azure.Messaging.ServiceBus.ServiceBusMessageBatch batch = await sender.CreateMessageBatchAsync())
{
batch.TryAddMessage(message);
int droppedCount = 0;
long droppedBodyBytes = 0;
foreach (Azure.Messaging.ServiceBus.ServiceBusMessage sbMessage in messageList)
{
if (!batch.TryAddMessage(sbMessage))
{
droppedCount++;
droppedBodyBytes += sbMessage.Body.ToMemory().Length;
}
}

if (droppedCount > 0)
{
TraceHelper.Trace(
TraceEventType.Error,
"MessageSender-SendAsync-MessagesDropped",
() => $"{droppedCount} message(s) ({droppedBodyBytes} body bytes) did not fit in the batch for '{sender.EntityPath}' " +
$"and were not sent; {batch.Count} message(s) were added to the batch (maximum batch size: {batch.MaxSizeInBytes} bytes).");
}

await sender.SendMessagesAsync(batch);
}

await sender.SendMessagesAsync(batch);
}

public async Task CloseAsync()
Expand Down
Loading