Fix native debug trace formatting in Apple test runners - #253
Open
matthargett wants to merge 1 commit into
Open
matthargett wants to merge 1 commit into
matthargett wants to merge 1 commit into
Conversation
The trace callback receives const char*, but NSLog was given %@, which interprets that pointer as an Objective-C object. Use %s for the C string on both macOS and iOS so diagnostic tracing does not send messages to an invalid object. Both entry points compile with -Werror=format and emit the expected sentinel through the real DebugTrace callback in a macOS harness.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The macOS and iOS test runners pass
const char*trace output toNSLog(@"%@", ...), which treats it as an Objective-C object and can crash when diagnostics are enabled. Use%sin both callbacks.Both entry points compile with
-Werror=formatand emit the expected message through the realDebugTrace::Tracecallback in a macOS harness. No iOS device run was performed.