Skip to content

fix(review): reject forbidden Claude tool use - #165

Merged
BaseInfinity merged 1 commit into
mainfrom
fix/issue-158-reject-review-tools-v2
Aug 22, 2026
Merged

BaseInfinity merged 1 commit into
mainfrom
fix/issue-158-reject-review-tools-v2

Conversation

@BaseInfinity

Copy link
Copy Markdown
Owner

Closes #158

What changed

  • reject Claude reviewer *_tool_use events from top-level, content-block, nested assistant-message, and array-wrapped stream envelopes
  • terminate the reviewer and preserve INVALID_VERDICT so later clean output, timeout classification, retry, or availability fallback cannot overwrite the rejection
  • deny advisor explicitly in review and availability-probe launches
  • flush the final unterminated JSON buffer before deciding the verdict

Verification

  • focused RED confirmed the availability probe could authorize fallback after forbidden tool use
  • focused GREEN covers that probe path and preserves legitimate quota/model fallback
  • canonical proof: 11/11 passed
  • adapter suite: 115/115 passed
  • final Sol High review: no actionable P0/P1/P2 findings

One-time owner exception

The ordinary Fable gate and a cleaner Opus attempt both emitted forbidden server-side advisor tool-use events. Those attempts remain invalid and are not relabeled as certified. The owner authorized one narrowly scoped meta-review bootstrap exception for #158 only: #158 (comment)

Commit af037604a6f8d8ac2b9a3279b176aebed61aefb5 is bound to reviewed tree a94df554b156bec706f65c274a301a2736f4e9fe and patch SHA-256 3771b360acd74e64ea21260d97e64f32f11f476bc74211ec4920d7ba509aed6d.

Closes #158

Review-Exception: one-time issue-158 meta-review bootstrap

Owner-Authorized: #158 (comment)

Reviewed-By: Sol High

Fable-Review: invalid-forbidden-advisor

Opus-Review: invalid-forbidden-advisor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(review): stop tool-free cross-model reviews when Claude invokes advisor

1 participant