Repository navigation
fix(windows): preserve transparent Recorder controls - #95
Merged
Merged
Conversation
|
Caution Review failedThe pull request is closed. Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ExtraBinoss
marked this pull request as ready for review
October 25, 2026 15:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows 0.5.6 can show an opaque gray/white rectangle around the recording controls. The shared HUD/Recorder window starts resizable with the default native backing/frame, then disables resizing after its first paint. Ordinary HUD/Recorder switches also reset the native backdrop even when preparation was never active.
Create the overlay with an explicit transparent background and fixed native dimensions from the outset, with the Windows resize frame disabled. Apply and remove preparation acrylic/vibrancy only when crossing the preparation-mode boundary. Programmatic sizing, recording controls, and the opaque editor window retain their existing behavior.
Validation: 75 focused Node tests pass for renderer creation, window-controller policies and preparation layout; both changed CommonJS modules pass
node --check.Windows visual validation is still pending: cold start, automatic and manual preparation paths, start/pause/resume/stop, and returning to the HUD. This environment cannot run the Windows compositor, so the draft does not claim the photographed artifact has been visually eliminated. No app version or release is changed.