Extract shared executor runtime with a Bukkit lifecycle adapter - #313
Merged
Merged
Conversation
This was referenced Sep 8, 2026
BenCodez
marked this pull request as ready for review
September 8, 2026 02:54
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Second requested platform-preparation PR. Extract the existing executor/lifecycle implementation into
core/runtimeand the Bukkit-specific cleanup hooks intobukkit/runtime, in the current single Maven project.RuntimePlatformwith JDK-only executor and cleanup contracts.AdvancedCoreRuntime.AdvancedCoreLifecycleas the public compatibility facade. AdvancedCorePlugin already uses it, so the Bukkit path uses the extracted implementation immediately.Compatibility and scope
One POM, no submodules, no new workflows, no dependency/version changes, and no AdvancedCorePlugin public API changes. The existing BukkitScheduler/Folia behavior is untouched. This does not redirect entity/region work to a global executor.
This is the executor/lifecycle slice, not a complete native AdvancedCore service graph. User/storage/reward services and final native artifact packaging remain separate steps. There is no duplicate user cache or second service registry. Existing lifecycle serialization and synchronous cleanup behavior remain; the executor grace periods are not a global timeout for arbitrary cleanup callbacks.
Verified build
Existing Java CI with Maven — run 530 passed on Java 21. Inspected build job
101919368836and its actual Maven log:mvn -B -f AdvancedCore/pom.xml package— BUILD SUCCESS.AdvancedCore.jarwas generated and normal shading/minimization completed.dc303c9aeea529f58e9a6c1a950830e7f2602c34for head50eb4bec1a0e0c42c757d428fa3ce778af3e7cb2and base5fe205bca26236a92ee2fda1634f056639b307a3.Local Java 21 compilation of the two shared production classes also passed. A local JDK-only smoke program ran a real task, checked independent executor owners and cleanup order, verified termination, and verified rejection after shutdown.
The editing container has no Maven/dependency network access. The full Maven result is from GitHub Actions, not a local Maven run. No current downstream VotingPlugin build, live-server test or live-database matrix was run. Source inspection was same-context; no independent reviewer execution is claimed.
Related work
These initial AdvancedCore PRs have disjoint production changes and independently target master. This lifecycle slice does not require SimpleAPI#78 to be published or merged.
Nothing is merged, deployed or published by this PR.
AI disclosure: This implementation and pull-request description were prepared with assistance from ChatGPT.