Extract platform-neutral configuration binding with Bukkit compatibility - #75
Merged
Merged
Conversation
Move the existing binding rules behind ConfigView and retain AnnotationHandler as a Bukkit-compatible facade. Add legacy behavior characterization and an isolated headless fixture without changing dependencies or artifact layout.
BenCodez
marked this pull request as ready for review
September 7, 2026 22:16
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First, deliberately narrow step toward reusing SimpleAPI/AdvancedCore/VotingPlugin on Fabric, Forge and NeoForge without maintaining separate configuration logic.
ConfigViewcontract.AnnotationBinder, preserving ordering, defaults, alternate paths, list fallback, duration parsing and per-field exception isolation.AnnotationHandler()andload(ConfigurationSection, Object)signatures. The Bukkit facade delegates through a liveBukkitConfigView; native section identity/mutability is retained for bothConfigurationSectionandObjectfields.load(ConfigView, ...)overload to the old class, avoiding ambiguity for existingload(null, target)calls.Compatibility / scope
simpleapi-coreartifact or a loader implementation. Production Configurate adapters and physical module separation follow after this boundary is validated.Verified GitHub Actions build
Java CI with Maven — run 179 passed on JDK 21.
mvn -B -f SimpleAPI/pom.xml packageSimpleAPI/target/SimpleAPI.jar, successful shading andBUILD SUCCESS.101866019948.fe70bd562283081ddaece09a0e16c9d651610150.9ec5f3522786b6fc3bedb54ad24cd04abfddc320, merging that candidate into basec4a37e5774dfbbf146ff6db20d19ac65310e4a8c.Additional checks
AnnotationHandler.javamatches upstream Git blob66591d8fa68bdfde47790c99f8c76748b91261efbyte-for-byte.git diff --cached --check— passed on the proposed files.ConfigViewcompilation withjavac --release 21— passed locally.Remaining validation before merge
The editing environment has Java 21 but no Maven or network access for build dependencies. The full SimpleAPI build and test results above are from GitHub Actions, not a local Maven build.
AdvancedCore and VotingPlugin have not yet been built against the candidate SimpleAPI artifact, and no live server smoke test has been performed. Keep this PR draft until those downstream compatibility checks are complete. Install the candidate into an isolated Maven repository and ensure downstream builds actually resolve that exact candidate rather than a mutable remote snapshot.
AI disclosure: This implementation and pull-request description were prepared with assistance from ChatGPT.