Propagate PlayerCommandHandler force-console mode

[BenCodez]

Summary

• propagate the six-argument PlayerCommandHandler constructor's forceConsole flag to the base command handler
• preserve existing constructor signatures and ordinary allowConsole behavior
• characterize player rejection, console acceptance, and normal console policy

Validation

• focused constructor/dispatch tests: 4 passed
• clean Maven package: 409 standard tests plus packaged-artifact validation passed
• git diff --check: passed
• fresh independent read-only review: no findings

Summary by CodeRabbit

• Bug Fixes

  • Commands created with the six-argument constructor now correctly apply the force-console setting.

• Tests

  • Added coverage for force-console handling, console access, and existing constructor defaults.

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-09-26T22:19:00.935142Z	5b79c99	PR opened
🔒 Security Review	✅ Completed 2026-09-26T22:20:28.141714Z	5b79c99	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 72dca45c-24c5-47ad-b855-33d84add20a8

📥 Commits

Reviewing files that changed from the base of the PR and between 3e5ddc2 and 5b79c99.

📒 Files selected for processing (2)

• SimpleAPI/src/main/java/com/bencodez/simpleapi/command/PlayerCommandHandler.java
• SimpleAPI/src/test/java/com/bencodez/simpleapi/tests/PlayerCommandHandlerTest.java

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.

📜 Recent review details

⏰ Context from checks skipped due to timeout. (3)

• GitHub Check: build
• GitHub Check: Analyze (actions)
• GitHub Check: Analyze (java-kotlin)

---

📝 Walkthrough

Walkthrough

The six-argument PlayerCommandHandler constructor now forwards forceConsole to CommandHandler. New tests cover sender handling, allowConsole behavior, and defaults in the existing constructors.

Changes

Force-console handling

Layer / File(s)	Summary
Forward forceConsole and verify handler behavior SimpleAPI/src/main/java/com/bencodez/simpleapi/command/PlayerCommandHandler.java, SimpleAPI/src/test/java/com/bencodez/simpleapi/tests/PlayerCommandHandlerTest.java	The constructor passes forceConsole to the parent constructor. Tests cover player and console sender handling, allowConsole behavior, constructor defaults, and test handler setup.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 5b79c

The change appears ready to merge after normal checks; no material risk remains identified.

Security Architecture Review

Security architecture risk: 🔵 Low · up to 5b79c

The change restricts player access for handlers that request console-only execution. Console access remains subject to the existing settings and permission check. No security issue was identified, though use by consumers outside this repository is not established.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

• inferred — The changed sender policy applies to handlers instantiated through the six-argument PlayerCommandHandler overload; repository evidence does not establish the number of external consumers.

Trust Boundaries and Controls

• observed — CommandSender type determines the player-versus-console boundary. The forwarded flag closes player execution for console-only handlers without removing the existing console eligibility or permission controls.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 17 functions across 2 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: forwarding the PlayerCommandHandler force-console mode.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

---

_{Comment @coderabbitai help to get the list of available commands.}