Fire PlayerDeathsChangedEvent from admin deaths commands - #3093
Merged
Merged
Conversation
Addons that keep their own death counts (Level tracks deaths per island since 2.29.0) had no way to know when an admin changed a player's deaths, so /<admin> deaths set|add|remove|reset silently did nothing to them. The four admin deaths commands now fire PlayerDeathsChangedEvent with the world, player, action, requested amount, and old/new counts. It is not fired for natural deaths or the automatic new-island/team-join resets. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Since Level 2.29.0, Level tracks death handicaps per island in its own data instead of reading BentoBox's per-world player counter. As a result,
/bsbadmin deaths set|add|remove|resetchanges BentoBox's counter but has no effect on island levels (reported on Discord: an admin removed 3 deaths, and/is levelstill showed(3 deaths)). Rather than duplicating the command in Level, core should tell addons when an admin changes deaths.What
world.bentobox.bentobox.api.events.player.PlayerDeathsChangedEvent(@since 3.23.1): world, player UUID,Action(SET/ADD/REMOVE/RESET), the amount the admin requested, and old/new counts.getAmount()is the requested amount, soremove 3is reported as 3 even when core's count is clamped at 0. Addons with their own counts need this.AdminDeathsCommandsTestchecks each command fires the event with the right values, and that invalid input fires nothing.Level side: companion PR in BentoBoxWorld/Level (follows).
🤖 Generated with Claude Code