Repository navigation
Fix issue 380: ensure that prif_allocate(_coarray) defines stat=0 upon success - #381
Merged
Merged
Conversation
Fixes issue 380
These macros were never officially supported, only provided an imperfect emulation since changes in PRIF 0.8 and they no longer serve any practical purpose, they just needlessly complicate maintenance.
Homebrew is waaaaaay too spammy with their warning policy and we're fed up with seeing their harmless warnings polluting our workflow summary. Downgrade all Homebrew warnings to only appear in the log.
ktras
approved these changes
Oct 8, 2026
ktras
left a comment
ktras
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Thanks for the bug fix!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #380
The actual fix appears entirely in the first commit, which is deliberately minimal to allow for easy cherry-pick.
The remaining commits update test coverage to ensure we detect future regressions, and remove unnecessary dead code that complicates that testing.