Repository navigation
refactor: remove over-defensive fallbacks and consolidate duplicated helpers - #259
Merged
Merged
Conversation
- add kind/format/summary/archived_at via migration 0005 - archive documents by default and purge explicitly with cascaded sources/notes - include recent document summaries in agent context with a 4k-character budget - add search_research and get_research_document tools - accept validated citations in research output - cover repository, service, context, tools, and runtime tests
- render sanitized Markdown with raw HTML skipped and links as text - add an editor preview toggle and document kind labels - show stored citations in the task detail view - add tests for preview rendering and citation parsing
- add docs/AGENT_MEMORY.md covering memory layers, context budget, tools, citations, and write policy - document Markdown/metadata/soft-delete conventions in DATA_MODEL.md - update AGENT_PROTOCOL, ARCHITECTURE, CLAUDE.md, roadmap, and changelog
EmptyContextProvider keeps the task's workspace id, not the task id.
- unify AgentService transitions; repository writes return updated rows - replace ExecutionResult fields with an enum - reject unknown persisted enum values instead of defaulting - keep the OpenAI HTTP timeout when the client build fails - make UpdateWorkspaceInput.name required - share text helpers, enum string mappings, and test database setup - add regression tests for enum parsing and workspace trimming Refs #258
BerryUIKI
changed the base branch from
feature/research-context-tools
to
main
November 7, 2026 06:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the P1/P2 cleanup tracked in #258.
AgentServicetask transitions; repository writes return the updated row viaUPDATE ... RETURNING.ExecutionResult's boolean/error fields and the duplicateFinalStatewith a single enum.Created/TaskCreated/Pending.reqwest::Clientconstruction fails.UpdateWorkspaceInput.namerequired.required_text/truncate, status/event string mappings, and the in-memory SQLite test setup.format!-built purge SQL and checkNotFoundbefore committing.Verification
cargo fmt --all -- --checkcargo test -p domain— 5 passedcargo check -p investment-os --all-targets— exit 0cargo check -p alphaforge-cli --all-targets— exit 0cargo test -p investment-os --liband clippy did not complete because several concurrent cargo builds on the workstation kept the target directory locked; no failures were observed before the run was stopped.Stacking
This branch is based on
feature/research-context-tools(#257) because the refactor touches files introduced there. It should be merged after #257; GitHub will retarget this PR tomainonce #257 lands.Closes #258