Skip to content

Rename numgaps, mingap, maxgap - #101

Merged
mszell merged 1 commit into
mainfrom
chore/polish-minmaxgap-names
Oct 20, 2026
Merged

mszell merged 1 commit into
mainfrom
chore/polish-minmaxgap-names

Conversation

@mszell

@mszell mszell commented Oct 20, 2026

Copy link
Copy Markdown
Member

Description

Rename numgaps, mingap, maxgap

Related Issue

Fixes #100

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 📝 Documentation update
  • 🧹 Code refactor (no functional changes)
  • ✅ Test update

How Has This Been Tested?

  • Unit tests
  • Integration tests
  • Manual testing

Test configuration:

  • OS:

Screenshots (if applicable)

Checklist

all applicable

  • My code follows the project's style guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix/feature works
  • New and existing tests pass locally

Additional Notes

@codecov

codecov Bot commented Oct 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 69.56522% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
fixbikenet/functions.py 50.00% 2 Missing and 3 partials ⚠️
fixbikenet/fixbikenet.py 71.42% 1 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@mszell
mszell merged commit 37ac295 into main Oct 20, 2026
12 of 13 checks passed
@mszell
mszell deleted the chore/polish-minmaxgap-names branch October 20, 2026 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant