feat(sdk-core): support stuck transaction age filters - #9567
Open
bitgo-ai-agent-dev[bot] wants to merge 3 commits into
Open
feat(sdk-core): support stuck transaction age filters#9567bitgo-ai-agent-dev[bot] wants to merge 3 commits into
bitgo-ai-agent-dev[bot] wants to merge 3 commits into
Conversation
Contributor
ralph-bitgo
Bot
force-pushed
the
WCN-2443-support-unconfirmed-age
branch
from
August 26, 2026 03:41
891d590 to
bdc28bd
Compare
bitgo-ai-agent-dev
Bot
force-pushed
the
WCN-2443-support-unconfirmed-age
branch
3 times, most recently
from
August 28, 2026 18:52
4d1f47e to
ce06ccf
Compare
Forward optional unconfirmed age filters through the wallet stuck transaction API. This lets callers avoid treating newly broadcast transactions as stuck without constructing query strings, while preserving opt-in behavior. Ticket: WCN-2443 Session-Id: 692d7cfe-5c58-429c-9202-245a2baf6534 Task-Id: 4b9b5bb9-b30d-415e-ac5f-9f15f753c9a2
bitgo-ai-agent-dev
Bot
force-pushed
the
WCN-2443-support-unconfirmed-age
branch
2 times, most recently
from
August 28, 2026 18:52
f1239f3 to
490936f
Compare
davidkaplanbitgo
marked this pull request as ready for review
August 31, 2026 15:17
| pendingApprovals(): IPendingApproval[]; | ||
| refresh(params?: Record<string, never>): Promise<IWallet>; | ||
| transactions(params?: PaginationOptions): Promise<any>; | ||
| getPotentialStuckTxs(params?: GetPotentialStuckTxsOptions): Promise<any>; |
Contributor
There was a problem hiding this comment.
Rather than Promise<any>, consider giving this a real return type. The response is an array where each entry is either an ETH-style stuck tx (cause, message, optional nonce/txId/txHex/gasAccelerationFee/etc.) or a UTXO-style one (txId required, optional rbf). Something like:
export interface GetPotentialStuckTxsResult {
txId?: string;
cause?: string;
message?: string;
nonce?: number;
txHex?: string;
txType?: string;
sendTransfer?: Record<string, unknown>;
gasAccelerationFee?: { gasPrice?: string; maxFeePerGas?: string; maxPriorityFeePerGas?: string };
userActionDisabled?: boolean;
rbf?: boolean;
coin?: string;
wallet?: string;
isFeeAddress?: boolean;
}
getPotentialStuckTxs(params?: GetPotentialStuckTxsOptions): Promise<GetPotentialStuckTxsResult[]>;Would tighten this up for consumers without needing to model the full union precisely.
Expose a structured result type for potential stuck transactions instead of Promise<any>, so consumers can safely access fields shared by ETH and UTXO responses without losing the endpoint's union shape. Ticket: WCN-2443 Session-Id: 692d7cfe-5c58-429c-9202-245a2baf6534 Task-Id: 4b9b5bb9-b30d-415e-ac5f-9f15f753c9a2
bitgo-ai-agent-dev
Bot
force-pushed
the
WCN-2443-support-unconfirmed-age
branch
from
August 31, 2026 15:50
5c38c72 to
0724e2e
Compare
Keep the existing TransfersOptions interface intact after adding the typed stuck transaction result so sdk-core and dependent packages compile. Ticket: WCN-2443 Session-Id: 692d7cfe-5c58-429c-9202-245a2baf6534 Task-Id: 4b9b5bb9-b30d-415e-ac5f-9f15f753c9a2
bitgo-ai-agent-dev
Bot
force-pushed
the
WCN-2443-support-unconfirmed-age
branch
from
August 31, 2026 16:14
6b887cc to
1e41ba1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
along with existing endpoint query options.
Why
transactions are not surfaced as needing acceleration, while preserving the
endpoint's existing opt-in and backward-compatible behavior.
Test plan
Ticket: WCN-2443