Repository navigation
Conversation
The physics baseline checks only the final row, so a closure drift that grew with time went unseen until #48. Simulate FourPostSim over its full heave and roll sequences and assert, on every output row, that the world-vertical contact forces and the jacking force sum to zero per axle. On zero-command rows, also assert that the chassis reaction has no in-plane force and no roll moment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Tests/modelica_physics_baseline.csvchecks only the final row. A FourPostSim closure residual grew linearly with time to 3.8 N at 118 s, and no test caught it until #48 fixed it. This test checks every output row, so a drift like that fails CI.What changes
Tests/test_four_post_closure.py. It simulatesBobLib.Experiments.Standards.FourPostSimover its default 0 to 118 s heave and roll sequences.<axle>KnC.jackingForcemust sum to less than 1e-3 N. The test resolves<axle>AxleDW.<side>CP.fto world z throughR.T. TireFzis clamped at zero during lift-off (t = 42 to 56 s), soFzcannot show closure on those rows.<axle>ChassisActuator.sprungLoads.frame_a.f[1]andf[2]must be below 1e-3 N, andt[1]must be below 1e-3 N·m.test_*.pywildcard puts it inmake test-additional(the OpenModelica Component Contracts job). No makefile, CI or model changes.Evidence
f[1]andf[2], and 2.3e-10 N·m or less fort[1].make lintandmake modelica-lintpass. Measured with OMC 1.27.1, MSL 4.1.0 and VI 2.0.2.Limits
make test-additionalwas not run locally. CI runs it.Fzis 0 there.