Repository navigation
Send FourPost bar rates only to the rig bars that exist - #154
Merged
Merged
Conversation
FourPost sent each bar rate twice, to pFrStabar.barRate and to pVehicle.pFrStabar.barRate. The rig binds only pFrStabar. The executable logs the pVehicle override as applied, but it changes no output: a run without it gives bit-identical results. It also sent a rate of 0 for an axle with no bar, where the template value is already 0. Now FourPost sends the rig bar rate only, and only for an axle that has a bar in the vehicle file.
rhorvath02
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
FourPost sent each bar rate to both
pFrStabar.barRateandpVehicle.pFrStabar.barRate. The rig binds onlypFrStabar. A run without thepVehicleoverride is bit-identical. FourPost also sent a rate for an axle with no bar, which the stricter runner (PR 2 of this stack) would reject.Changes
FourPost sends the rig bar rate only, and only for an axle that has a bar.
How to check
A new test in
tests/test_kinematics.py. Robert's spring-curve test still passes.Notes
Stack
3 of 7.