feat(event_queue): get_many outcome metrics + wider get latency buckets - #215
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
event_queue_get_secondshistogram buckets from a 10s cap up to 30s (adds 15/20/30s, lower buckets untouched)event_queue_get_many_outcomes_total{queue, outcome}counter recording every successfulget_manyasfull,partial, oremptyWhy
get_oneidle waits (aiokafkagetone()blocks until a record exists) all collapsed into the overflow bucketget_manywe want to know whether calls came back with the desired records or hit the consume timeout.len(result) < countexactly identifies timeout-driven returns in the kafka batcher loop (a full batch always reachessize >= countfirst), so no protocol or adapter changes were neededoutcomedistinguishes fully-empty polls from partial batchesNotes
emptyoutcomesget_manycan overshootcountacross partitions, so>= countmaps tofullTesting
uv run mypycleanuv run ruff check/uv run ruff format --check .cleanuv run pytest— 200 passed (new: parametrized_get_many_outcomeclassification + outcome/error metric tests)