Skip to content

fix: filter +autoz QA telemetry - #4526

Merged
steve8708 merged 7 commits into
mainfrom
changes-7077
Sep 8, 2026
Merged

fix: filter +autoz QA telemetry#4526
steve8708 merged 7 commits into
mainfrom
changes-7077

Conversation

@steve8708

@steve8708 steve8708 commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • suppress +autoz QA identities at the shared server/browser tracking boundaries, including direct PostHog feedback events
  • require +autoz in automated signup, beta, trusted-acceptance, and template QA identities
  • preserve legacy synthetic +qa compatibility for existing fixtures and recipient suppression, and update authentication guidance/locales

Validation

  • 71/71 repository guards
  • 120 core tests, 50 plan tests, 30 clips tests, 21 QA/trusted-acceptance tests
  • beta and signup TypeScript checks
  • oxfmt check and git diff check

…, docs/trusted-acceptance-lane.md, e2e/beta, … (53 files)
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Visual recap — generation failed

The visual recap could not be generated for this pull request. This is informational only and does not block the PR.

Diagnostic:

No plan URL: create-visual-recap failed 403 Forbidden: {"error":"Creating an org-visible visual recap requires an active organization. Connect Plan from an organization or publish with private visibility."}

Agent output: Wrote recap-source.json for CI’s deterministic publisher. It covers all 53 changed files and includes six annotated key-change tabs. --- ⠀ 🟢 Visual recap source is ready for CI publication. stderr: Reading additional input from stdin...

@netlify

This comment has been minimized.

builder-io-integration[bot]

This comment was marked as outdated.

builder-io-integration[bot]

This comment was marked as outdated.

builder-io-integration[bot]

This comment was marked as outdated.

# Conflicts:
#	packages/core/docs/content/cross-app-sso.mdx
#	packages/core/docs/content/locales/ar-SA/cross-app-sso.mdx
#	packages/core/docs/content/locales/de-DE/cross-app-sso.mdx
#	packages/core/docs/content/locales/es-ES/cross-app-sso.mdx
#	packages/core/docs/content/locales/fr-FR/cross-app-sso.mdx
#	packages/core/docs/content/locales/hi-IN/cross-app-sso.mdx
#	packages/core/docs/content/locales/ja-JP/cross-app-sso.mdx
#	packages/core/docs/content/locales/ko-KR/cross-app-sso.mdx
#	packages/core/docs/content/locales/pt-BR/cross-app-sso.mdx
#	packages/core/docs/content/locales/zh-CN/cross-app-sso.mdx
#	packages/core/docs/content/locales/zh-TW/cross-app-sso.mdx

@builder-io-integration builder-io-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builder reviewed your changes — looks good ✅

Review Details

Code Review Summary

This incremental review covers the latest PR head after fixes to AuthPage signup-view timing, AuthPage Google click timing, Clips public-share Google timing, and direct PostHog synthetic-traffic suppression. Direct inspection confirms those previously reported issues are fixed: signup-view tracking now requires a valid normalized email and only tracks once while on the signup view; AuthPage Google tracking occurs after the OAuth exchange supplies an email; the public-share Google path gates both events on the authenticated email; and sendPostHogEvent() checks the request synthetic-traffic flag.

The shared +autoz matcher remains narrowly scoped, the existing synthetic patterns remain intact, and the updated QA fixtures consistently use the new marker. No additional confirmed issues were identified in this incremental pass. The parallel worker calls were interrupted before returning findings, so this review records the verified latest-head inspection without inventing unconfirmed comments. Risk level: Standard.

🧪 Browser testing: Will run after this review (PR touches UI code).

@steve8708
steve8708 merged commit b6bd189 into main Sep 8, 2026
48 checks passed
@steve8708
steve8708 deleted the changes-7077 branch September 8, 2026 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant