fix: filter +autoz QA telemetry - #4526
Conversation
…, docs/trusted-acceptance-lane.md, e2e/beta, … (53 files)
Visual recap — generation failedThe visual recap could not be generated for this pull request. This is informational only and does not block the PR. Diagnostic: No plan URL: create-visual-recap failed 403 Forbidden: {"error":"Creating an org-visible visual recap requires an active organization. Connect Plan from an organization or publish with private visibility."} Agent output: Wrote recap-source.json for CI’s deterministic publisher. It covers all 53 changed files and includes six annotated key-change tabs. --- ⠀ 🟢 Visual recap source is ready for CI publication. stderr: Reading additional input from stdin... |
This comment has been minimized.
This comment has been minimized.
# Conflicts: # packages/core/docs/content/cross-app-sso.mdx # packages/core/docs/content/locales/ar-SA/cross-app-sso.mdx # packages/core/docs/content/locales/de-DE/cross-app-sso.mdx # packages/core/docs/content/locales/es-ES/cross-app-sso.mdx # packages/core/docs/content/locales/fr-FR/cross-app-sso.mdx # packages/core/docs/content/locales/hi-IN/cross-app-sso.mdx # packages/core/docs/content/locales/ja-JP/cross-app-sso.mdx # packages/core/docs/content/locales/ko-KR/cross-app-sso.mdx # packages/core/docs/content/locales/pt-BR/cross-app-sso.mdx # packages/core/docs/content/locales/zh-CN/cross-app-sso.mdx # packages/core/docs/content/locales/zh-TW/cross-app-sso.mdx
There was a problem hiding this comment.
Builder reviewed your changes — looks good ✅
Review Details
Code Review Summary
This incremental review covers the latest PR head after fixes to AuthPage signup-view timing, AuthPage Google click timing, Clips public-share Google timing, and direct PostHog synthetic-traffic suppression. Direct inspection confirms those previously reported issues are fixed: signup-view tracking now requires a valid normalized email and only tracks once while on the signup view; AuthPage Google tracking occurs after the OAuth exchange supplies an email; the public-share Google path gates both events on the authenticated email; and sendPostHogEvent() checks the request synthetic-traffic flag.
The shared +autoz matcher remains narrowly scoped, the existing synthetic patterns remain intact, and the updated QA fixtures consistently use the new marker. No additional confirmed issues were identified in this incremental pass. The parallel worker calls were interrupted before returning findings, so this review records the verified latest-head inspection without inventing unconfirmed comments. Risk level: Standard.
🧪 Browser testing: Will run after this review (PR touches UI code).
Summary
Validation