Repository navigation
fix: Synchronize music streams started in the same frame - #653
Merged
cobaltgit merged 1 commit intoOct 24, 2026
Merged
Conversation
We now delay streamed-audio starts until the audio update, then schedule them together on the mixer clock. This prevents loading one music layer from putting it behind another. pauses cancel pending starts, and resumes use the same scheduling. This fixes off-sync music in both DELTARUNE Chapter 3 and 5 (and 4? i think 4 has a little lightners live thing in castle town) when playing the Lightners Live segment.
Collaborator
|
Yeah chapter 4 has the lightners live minigame too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now delay streamed-audio starts until the audio update, then schedule them together on the mixer clock.
This prevents loading one music layer from putting it behind another. This fixes off-sync music in both DELTARUNE Chapter 3 and 5 (and 4? i think 4 has a little lightners live thing in castle town) when playing the Lightners Live segment.