Skip to content

Update Banner wordmark: joined lines, bold, leaning mascot, and a banner_style setting - #7

Merged
yoelrosenthal merged 5 commits into
masterfrom
fix-banner-wordmark-bold
Sep 17, 2026
Merged

yoelrosenthal merged 5 commits into
masterfrom
fix-banner-wordmark-bold

Conversation

@yoelrosenthal

@yoelrosenthal yoelrosenthal commented Sep 17, 2026 •

Copy link
Copy Markdown
Member

Summary

Follow-ups to the mascot banner from #6.

  • Joined-line wordmark. Today's letter shapes and spacing are unchanged, but the ASCII strokes are drawn with joined line characters: ╱ ╲ for the slants, │ for verticals, and ▁ for bottom lines, so the strokes of each letter meet.
  • banner_style setting. The joined wordmark needs a terminal that draws box-drawing characters itself. Terminals that take them from the font, Warp and the classic Windows console among them, leave gaps between the strokes. banner_style in config.json defaults to joined; ascii picks the plain fallback.
  • Bold. Restores the bold modifier the wordmark lost when it got its own purple style.
  • Leaning mascot. The mascot's top rows sit one column right of its bottom two, as in the pre-Add animated mascot banner and tidy the public-release metadata #6 banner. The lean lives in the mascot art only, since shifting whole rows would pull the joined strokes apart.

The setting

  • Config: "banner_style": "joined" | "ascii". Configs written before this keep loading and get joined.
  • CLI: agentp config set --banner-style ascii, and agentp config show prints it.
  • TUI: a new Banner Style row on the config screen toggles it, like Default Mode.
  • Both wordmarks place the letters in the same columns, so switching never moves the banner. A test enforces that, and another checks the fallback is pure ASCII.

Verification

  • cargo fmt --all -- --check, cargo clippy --all-targets -- -D warnings, and cargo test (112 tests) pass.
  • Ran the TUI in Windows Terminal in both styles and rendered the config screen to a test terminal to check the new row.
  • Exercised config show and config set --banner-style and confirmed the value persists to config.json.

🤖 Generated with Claude Code

Note

Add configurable banner_style setting and update banner wordmark art

  • Adds banner_style to Config and ConfigFile in data.rs, defaulting to joined with ascii as an alternative.
  • Updates draw_banner in banner.rs to render the selected wordmark in bold, with joined lines and a leaning mascot.
  • Adds a "Banner Style" row to the TUI config menu in config_screen.rs and a --banner-style flag to the CLI config set command.
  • Fixes config_toggle_default_mode to restore the previous mode in memory if persisting fails.
  • Behavioral Change: config_activate_row shifts all row dispatches after row 3 by one position due to the new "Banner Style" row; CONFIG_MENU_ITEM_COUNT in state.rs updates from 8 to 9.

Macroscope summarized 767c8d9.

Giving the wordmark its own purple style dropped the bold modifier the
banner always had, so the letters rendered thin and faint. Restore it.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

You're on the cubic free plan with 8 free PR reviews remaining this month. Upgrade for unlimited reviews.

Re-trigger cubic

The old banner centered rows of different widths, which left its bottom
two rows one column left of the rest. That gave the mascot's stand and
the wordmark a slight lean to the right, and the refactor that fixed the
centering removed it. Keep the look on purpose: the top four rows get
one leading space.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@yoelrosenthal yoelrosenthal changed the title Fix Draw the banner wordmark in bold again Fix Restore the banner's bold wordmark and rightward lean Sep 17, 2026
Keep today's letter shapes and spacing, but draw them with box-drawing
diagonals, a centered vertical, and a lower one-eighth block, so the
strokes of each letter meet instead of floating in separate cells.

Shifting whole rows would pull the joined strokes apart, so the lean now
lives in the mascot art alone, with the same offsets as before.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@yoelrosenthal yoelrosenthal changed the title Fix Restore the banner's bold wordmark and rightward lean Update Joined-line banner wordmark, bold, and leaning mascot Sep 17, 2026
The joined wordmark needs a terminal that draws box-drawing characters
itself. Terminals that take them from the font, Warp and the classic
Windows console among them, leave gaps between the strokes.

Add `banner_style` to config.json, defaulting to `joined`, with `ascii`
selecting the plain fallback. Both wordmarks place the letters in the
same columns, so switching never moves the banner. The setting is
reachable from `agentp config set --banner-style` and a new Banner Style
row on the TUI config screen, and configs written before it keep loading.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@yoelrosenthal yoelrosenthal changed the title Update Joined-line banner wordmark, bold, and leaning mascot Update Banner wordmark: joined lines, bold, leaning mascot, and a banner_style setting Sep 17, 2026
Comment thread src/app/config_screen.rs
The config screen flipped default_mode or banner_style in memory before
saving, so a failed write left the screen showing a value that was not
on disk and the change vanished on restart. Both toggles now restore the
previous value when the save fails.

Also trims the README note about banner_style to a sentence.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Comment thread src/app/config_screen.rs
@yoelrosenthal
yoelrosenthal merged commit 03a973c into master Sep 17, 2026
6 checks passed
@yoelrosenthal
yoelrosenthal deleted the fix-banner-wordmark-bold branch September 18, 2026 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant