Update Banner wordmark: joined lines, bold, leaning mascot, and a banner_style setting - #7
Merged
Merged
Conversation
Giving the wordmark its own purple style dropped the bold modifier the banner always had, so the letters rendered thin and faint. Restore it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
No issues found across 1 file
You're on the cubic free plan with 8 free PR reviews remaining this month. Upgrade for unlimited reviews.
Re-trigger cubic
The old banner centered rows of different widths, which left its bottom two rows one column left of the rest. That gave the mascot's stand and the wordmark a slight lean to the right, and the refactor that fixed the centering removed it. Keep the look on purpose: the top four rows get one leading space. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Keep today's letter shapes and spacing, but draw them with box-drawing diagonals, a centered vertical, and a lower one-eighth block, so the strokes of each letter meet instead of floating in separate cells. Shifting whole rows would pull the joined strokes apart, so the lean now lives in the mascot art alone, with the same offsets as before. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The joined wordmark needs a terminal that draws box-drawing characters itself. Terminals that take them from the font, Warp and the classic Windows console among them, leave gaps between the strokes. Add `banner_style` to config.json, defaulting to `joined`, with `ascii` selecting the plain fallback. Both wordmarks place the letters in the same columns, so switching never moves the banner. The setting is reachable from `agentp config set --banner-style` and a new Banner Style row on the TUI config screen, and configs written before it keep loading. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The config screen flipped default_mode or banner_style in memory before saving, so a failed write left the screen showing a value that was not on disk and the change vanished on restart. Both toggles now restore the previous value when the save fails. Also trims the README note about banner_style to a sentence. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-ups to the mascot banner from #6.
╱╲for the slants,│for verticals, and▁for bottom lines, so the strokes of each letter meet.banner_stylesetting. The joined wordmark needs a terminal that draws box-drawing characters itself. Terminals that take them from the font, Warp and the classic Windows console among them, leave gaps between the strokes.banner_styleinconfig.jsondefaults tojoined;asciipicks the plain fallback.The setting
"banner_style": "joined" | "ascii". Configs written before this keep loading and getjoined.agentp config set --banner-style ascii, andagentp config showprints it.Verification
cargo fmt --all -- --check,cargo clippy --all-targets -- -D warnings, andcargo test(112 tests) pass.config showandconfig set --banner-styleand confirmed the value persists toconfig.json.🤖 Generated with Claude Code
Note
Add configurable
banner_stylesetting and update banner wordmark artbanner_styletoConfigandConfigFilein data.rs, defaulting tojoinedwithasciias an alternative.draw_bannerin banner.rs to render the selected wordmark in bold, with joined lines and a leaning mascot.--banner-styleflag to the CLIconfig setcommand.config_toggle_default_modeto restore the previous mode in memory if persisting fails.config_activate_rowshifts all row dispatches after row 3 by one position due to the new "Banner Style" row;CONFIG_MENU_ITEM_COUNTin state.rs updates from 8 to 9.Macroscope summarized 767c8d9.