Repository navigation
fix(pipeline): match pcgv2's root ids, root verify and mesh failures - #548
Merged
Merged
Conversation
akhileshh
commented
Oct 21, 2026
akhileshh
commented
Contributor
- Ingest draws root ids from the sharded root counters on the serial path too, as edits and pcgv2 do.
- The root verify skips the cross-edge check when no sampled chunk has cross edges.
- Meshing returns fatal for a bug-class error and passes a uint64 chunk id; ValueError stays transient because tensorstore raises it for I/O.
- Ingest draws root ids from the sharded root counters on the serial path too, as edits and pcgv2 do. - The root verify skips the cross-edge check when no sampled chunk has cross edges. - Meshing returns fatal for a bug-class error and passes a uint64 chunk id; ValueError stays transient because tensorstore raises it for I/O. Co-Authored-By: Claude <noreply@anthropic.com>
- The conda env no longer installs `tox`, whose `pluggy`, `packaging` and friends pip replaced with the lockfile's pins; `conda-pack` packed a mix of both, and pytest failed to import `pluggy._caller`. - `scipy`, `cffi` and `pycparser`, which conda installs with graph-tool, join `numpy` as pip-tools unsafe packages, so the lock no longer pins them over conda's copies. Co-Authored-By: Claude <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## pcgv3 #548 +/- ##
==========================================
- Coverage 67.55% 67.51% -0.04%
==========================================
Files 89 89
Lines 8638 8643 +5
Branches 1149 1149
==========================================
Hits 5835 5835
- Misses 2614 2619 +5
Partials 189 189
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.