Repository navigation
fix(exports): secure export signing and storage endpoints - #1546
Open
To0yeni wants to merge 1 commit into
Conversation
|
@To0yeni Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #1510
Summary
Move export signing configuration into validated environment settings and reject unsafe storage endpoints.
Changes
Disable export routes unless all required export settings are configured.
Use the injected usage repository as the export data source.
Enforce HTTPS in production, block internal IP ranges, and support an optional hostname allowlist.
Encrypt scheduled-export secrets at rest and redact them in responses.
Add regression tests and update export documentation.
Testing
npm run build passed.
Export-focused tests passed: 50 tests.
Export env tests passed: 2 tests.
Validator and schedule-router line coverage exceeded 90%.
The full typecheck and lint were blocked by unrelated existing type errors and an AJV dependency issue in the installed environment.