Repository navigation
fix(catalog): target /api/apis and adapt backend rows - #1347
Merged
greatest0fallt1me merged 1 commit intoOct 19, 2026
Merged
Conversation
- Align CATALOG_PATH with backend route GET /api/apis using apiUrl() - Implement tolerant adaptBackendApi adapter mapping backend rows to APIItem - Preserve pricingOnRequest flag when endpoint pricing is absent - Send If-None-Match header and keep cached catalogue data on 304 response - Make backend fetch failures reject when API_BASE is configured to display error states - Display 'Sample data' indicator in demo mode when API_BASE is empty - Add comprehensive vitest suites for catalogApi adapter and MarketplacePage - Update Configuration.md with /api/apis backend contract notes Closes CalloraOrg#1327
|
@rupesh-kumar-sah Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves the contract mismatch between Callora-Frontend and Callora-Backend GET /api/apis.
Key fixes:
CATALOG_PATHto/api/apisconstructed viaapiUrl('/api/apis').adaptBackendApi(row)which:idto string.developer.nametoprovider.name,developer.websitetoprovider.url, andlogo_urltoprovider.avatar.base_urltobaseUrl.pricePerRequestfrom the minimum endpoint price. If pricing is omitted or 0 without endpoints, setspricingOnRequest: trueso cards display "Pricing on request".id == null).If-None-Matchusing cachedETagand reuse cached data on304 Not Modified.API_BASEis configured, fetch failures reject rather than silently falling back to sample data, surfacing stale-data or error states inMarketplacePage. When unconfigured, mock sample data is displayed with a "Sample data" indicator.docs/Configuration.mdwith/api/apisbackend path notes and contract specifications.Closes #1327
Verification
src/api/catalogApi.test.tscovering all 8 specified scenarios (15/15 passing, 95.97% line coverage).MarketplacePage.test.tsxintegration tests (3/3 passing).npx tsc -p tsconfig.json --noEmitpassed cleanly with 0 type errors.npm run buildsucceeded with 0 errors.