Repository navigation
feat(deposit): detect and add USDC trustline via Freighter - #1348
Merged
greatest0fallt1me merged 1 commit intoOct 19, 2026
Merged
Conversation
|
@iyiade08 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1316
Summary
Wallets without the vault’s classic USDC trustline previously reached deposit simulation and received a generic failure. The modal now detects the missing trustline and offers to add it through Freighter before depositing.
Validation
The service tests decode the actual XDR passed to mocked Freighter and assert exactly one changeTrust operation for the configured asset.
Full-suite output:
PowerShell settings used for the full-suite run:
Regression verification: the original main modal permits approval without the configured trustline and displays a generic failure when simulation is mocked to reject. The updated modal offers Add USDC trustline first.
Recording
Attach stellar.mp4 below this paragraph.
The recording shows Freighter approving the trustline and the app enabling Approve Transaction afterward. Horizon independently confirmed the new trustline.
The subsequent deposit remains blocked by deployment setup: simulation returns contract error 44, CallerNotInAllowlist. The wallet also has zero balance of the vault issuer’s test USDC. Maintainer allowlisting and matching test USDC are needed to complete the deposit recording.
Coverage limitation
The repository-wide npm run test:coverage run reported 73.67% line/statement coverage, below the configured 80% floor, with gaps in untouched modules.
The focused wallet service coverage run passes above 90%. Coverage thresholds and exclusions were not changed.
stellar.mp4