Repository navigation
feat(rate-limit): stacked plan cards on narrow screens - #1350
Merged
greatest0fallt1me merged 1 commit intoOct 21, 2026
Merged
Conversation
|
@praizeD10 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1324
Summary
Resolves the issue where the Rate Limit page's 4-column table causes mid-digit wrapping and overflow on viewports ≤ 375px (due to fixed 32px side padding on the page and 32px card padding, leaving only ~245px for four columns).
This PR:
16pxand card inner padding becomes20px.dl) with right-aligned tabular numerals.currentPlanprop toRateLimitCard: that plan's card (mobile) or row (desktop) receives a"Current plan"badge andaria-current="true".<style>to a dedicated CSS file (src/pages/RateLimitCard.css) to eliminate style re-injection on re-renders.PLAN_PATTERNS) and exposes descriptions to assistive technology in both layouts.Changes
src/pages/RateLimitCard.css:<style>tag.@media (max-width: 640px)rules for responsive page padding (0 16px 32px) and card padding (20px)..rate-limit-cards,.rate-limit-plan-card,.rate-limit-plan-dl,.rate-limit-dl-row,.rate-limit-current-badge,.rate-limit-number).font-variant-numeric: tabular-nums; white-space: nowrap;).src/pages/RateLimitCard.tsx:<style>element and importedRateLimitCard.css.currentPlan?: stringand optionalisMobile?: booleanprops.useMediaQueryhook checking viewport below 640px.src/pages/RateLimitCard.test.tsx:currentPlan="Pro"witharia-current, non-breaking tabular numbers, accessible pattern descriptions, absence of inline<style>, and breadcrumb middle-ellipsis preservation).Visual Verification & Screenshots
Test Output
Unit Tests (
RateLimitCard.test.tsx)