Repository navigation
fix(sla): resolve SLA page from selected API - #1351
Open
Agencybuilds wants to merge 2 commits into
Open
Agencybuilds wants to merge 2 commits into
Agencybuilds wants to merge 2 commits into
Conversation
|
@Agencybuilds Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1325
Summary
Resolves the SLA page dynamically per API rather than using a hardcoded GrantFox-only literal route.
sla?: { uptimeTargetPct: number; p99LatencyMs?: number; incidentResponseMinutes?: number; maintenanceWindow?: string; supportTier?: string; creditThresholdPct?: number }toAPIItem, and populated SLA terms for sample APIs./marketplace/:apiId/slainApp.tsxand updatedrenderRoute.tsxso/marketplace/:apiId/slapasses through toApp.tsxfor any API ID while preserving/marketplacestandalone rendering.fetchCatalog(signal).aria-busy="true".role="alert") with a link back to/marketplace.api.sla+api.versionwith individual copy-to-clipboard buttons andaria-livepolite feedback.Marketplace → api.name (linking to /details/:id) → SLA, and document title includes the API name.ApiDetailPage.docs/SlaCard-CopyToClipboard.mdandREADME.md.Test Plan
src/pages/SlaCard.test.tsx: 17 tests covering per-API SLA (geocode-01), no-SLA observed telemetry (translate-01), unknown ID not-found state, loading skeleton, and clipboard copy interactions.src/renderRoute.test.tsx: 4 tests validating routing exclusions for/marketplace/:apiId/sla, standalone/marketplace, query branches, and the ApiDetailPage SLA link.src/RouteSplitting.test.tsx: 7 tests passing.npx tsc -p tsconfig.json --noEmitandnpm run buildpass.