Repository navigation
feat(deposit): add status check and persisted pending deposit - #1354
Merged
greatest0fallt1me merged 1 commit intoOct 21, 2026
Merged
greatest0fallt1me merged 1 commit into
greatest0fallt1me merged 1 commit into
Conversation
|
@AugistineCreates Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1315
Summary
Resolves: Let users verify an unconfirmed deposit hash and recover the deposit modal.
When submitting a deposit times out or confirmation polling gives up, the modal previously locked into a permanent dead end with a disabled button and lost the hash across page reloads.
This PR adds:
checkDepositStatus(hash)to src/services/walletService.ts, querying Soroban RPCgetTransaction(hash)and returning"SUCCESS" | "FAILED" | "NOT_FOUND" | "UNKNOWN".{ hash, amount, submittedAt, network, contractId }insessionStorageundercallora:deposit:pending(guarded withtry/catchagainst private browsing exceptions). Clears the record on a definitive outcome (SUCCESS,FAILED, orNOT_FOUNDpast the validity window).checkDepositStatus.confirmedstate, updates vault balance (setVaultBalance), and clears storage.failedstate with Retry deposit enabled, and clears storage."You have an unconfirmed deposit"with a Check status action outside the modal on/billingwhen the modal is closed.role="status",aria-live="polite",sr-only) announce status updates without repeating countdown announcements every second.Test Verification Output
1. TypeScript Verification