Repository navigation
fix(api-detail): fetch by id and reset loading per id - #1361
Merged
greatest0fallt1me merged 1 commit intoOct 21, 2026
Conversation
|
@raskenite Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR replaces the fake, timer-based load on the API detail page with a real
GET /api/apis/:idfetch, and fixes the stuck skeleton that appears when navigating between APIs from the "Related APIs" rail. Loading, not-found and error states now reset correctly whenever the id changes, with proper abort handling and no state writes after unmount or id change.Related Issue
Changes
🔌 Catalog API client
src/api/catalogApi.tsfetchApiDetail(id, signal)that callsGET /api/apis/:id, reusing the existing row adapter from the catalogue path.NotFoundresult.CatalogFetchError.MOCK_APISwithout hitting the network.🖥️ API detail page
src/pages/ApiDetailPage.tsxfindApiByIdlookup and theLOADING_DELAY_MStimer.idwith anAbortControllerand astatus: "loading" | "ready" | "not-found" | "error"state.aria-busy, errors userole="alert", and focus is not stolen on load.Verification Results
idclears loading on every id changegrep -n "findApiById|LOADING_DELAY_MS" src/pages/ApiDetailPage.tsxreturns nothingnpx tsc -p tsconfig.json --noEmit,npm run buildandnpx vitest runpassCloses #1329