Skip to content

consider changing some SignatureTemplate methods to properties #308

Closed

Description

@mr-zwets

Currently SignatureTemplate has a method .getPublicKey() and getSignatureAlgorithm() but these could as well be a property because they do not accept any arguments.

In v0.8.0 we replaced a contract method to a property

BREAKING: Replace contract.getRedeemScriptHex() with contract.bytecode.

so this could have similar reasoning.

If getPublicKey() would accept an HD node path then it would make sense as a method I think, but the current API doesn't seem consistent

Activity

  1. rkalis commented on May 8, 2025

    @rkalis
    Member

    Yeah we should make these properties in some future breaking release.

  2. added this to the v0.12.0 milestone on May 8, 2025
  3. modified the milestones: v0.12.0, v0.13.0 on Jun 14, 2025
  4. linked a pull request that will close this issueBreaking changes to SignatureTemplate #440on Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    breakingbreaking changejavascript-sdkRelates to the CashScript JavaScript SDK

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions