Repository navigation
Conversation
Failed and stuck items now advance once without consuming unrelated queue tracks. Retries, notices, and health stay out of this change. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Failed and stuck tracks currently call
do_next()in a way that can skip unrelated queued songs. This change introduces a single queue consumer: LavalinkTrackEndreasons go through onePlaybackSession, andQUEUE_ADVANCEmoves exactly one logical item.Player.current,Queue.get/tracks/history) still returnTrack, not an internal queue wrapper.Tests
Vocard-function tests on this branch (not Lavalink/YouTube plugin behavior):
TrackEnd(loadFailed)/ stuck → exactly one advancementreplaceddoes not consume the next songTrackAlso ran upstream
python tests/runner.py(language packs + language usage + these playback tests) andpython -m compileall voicelink cogs.Notes
This replaces the oversized main-targeted PR with a smaller
betaslice. My personalfix/playback-reliabilityfork is unchanged (retries/notices/health stay on there).