Repository navigation
Bump gemd to 2.3.2 - #1065
Merged
Merged
Bump gemd to 2.3.2#1065
Conversation
gemd 2.3.x normalizes attribute template/bounds pairs to tuples. Update the object template serde test to replace pairs rather than mutate them, and assert that citrine templates expose tuples consistently with gemd. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kroenlein
marked this pull request as ready for review
October 14, 2026 19:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Citrine Python PR
Description
Updates gemd to 2.3.2, which includes CitrineInformatics/gemd-python#235. That change normalizes attribute template/bounds pairs on object templates to
(template, bounds)tuples instead of lists.citrine-python's template descriptors use
override=True, so they hand both get and set to gemd's properties and already produce tuples. No library code changes.Changes:
requirements.txt:gemd==2.2.4→gemd==2.3.2.test_object_template_serdeassigned into a pair (conditions[0][0] = ...), which raisesTypeErroron tuples. It now replaces the whole pair, and it asserts that citrine templates return tuples as gemd does.Heads-up for users: code that assigns into a template's attribute pair in place (
template.properties[i][0] = ...) will now raiseTypeErrorand must replace the whole pair. Thegemd>=2.1.9,<3range inpyproject.tomlis unchanged because citrine-python works with either version.PR Type:
Adherence to team decisions
🤖 Generated with Claude Code