Repository navigation
test(api_018): export download/landing URLs must point at the env under test - #191
Open
saqibmanan wants to merge 2 commits into
Open
saqibmanan wants to merge 2 commits into
saqibmanan wants to merge 2 commits into
Conversation
… under test The shape-only export tests stayed green while every dcat:downloadURL on dev pointed at api.civicdataspace.in, which does not resolve. xfail until DataSpaceBackend#238 is fixed and PUBLIC_API_URL/PUBLIC_SITE_URL are set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing
test_api_018export tests only check the document's shape. So they stayed green while everydcat:downloadURLon dev pointed atapi.civicdataspace.in, a host that doesn't resolve (DataSpaceBackend#238).Added (read-only, so they also run on prod)
test_export_download_urls_resolve_on_this_backend: every download URL is onAPI_BASE_URLand returns 200.test_export_landing_page_is_on_this_frontend:dcat:landingPageis onHOME_URL_DEV, i.e. the frontend paired with that backend.Verified on dev
PUBLIC_API_URL/PUBLIC_SITE_URLwere set, both failed for the right reason, e.g.download URL https://api.civicdataspace.in/... is not on the backend under test (https://dev.api.civicdataspace.in).deployed_pr#211) until DataSpaceBackend#239 deploys. Prod's.envis already set, so they should pass there.A failure here usually means the backend
.envon the target box is missing one of those two variables.