Repository navigation
Restore accessibility suite + fix signed-in dashboard scans - #192
Open
saqibmanan wants to merge 2 commits into
Open
saqibmanan wants to merge 2 commits into
saqibmanan wants to merge 2 commits into
Conversation
Recovered byte-identical from the untracked-files stash commit eeea1d0 (verified against the surviving .pyc). Includes vendored axe-core 4.10.2, the report generator, markers and the sessionfinish report hook.
The JS sidebar click never left the datasets view, so all five signed-in scans hit /dashboard/self/<slug>/dataset. Navigate to each section's URL (slug taken from the logged-in URL), assert the landing path, and scan the /dashboard hub for the dashboard check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #190
1. Restore (752b188)
The WCAG 2.1 AA suite was never committed and its source had disappeared from disk. I recovered it from untracked-files stash commit
eeea1d0. Each file compiles to bytecode identical to the surviving.pycfiles. Restored:tests/accessibility/utils/a11y.pyandlocators/accessibility_locators.pya11y_report_generator.pyaccessibility/widgetmarkers and thepytest_sessionfinishreport hook2. Fix (1b17a1e)
All 5 signed-in scans hit
/dashboard/self/<slug>/dataset, because the JS sidebar click never navigated. So usecases, charts, profile and the dashboard hub had never been scanned. Each section is now reached by URL: the slug comes from the logged-in URL, and the landing path is asserted before scanning. The "dashboard" check scans the/dashboardhub.Results on dev (2026-10-09)
aria-valid-attr-value). The fixed navigation surfaced #499; it's already on prod.CI impact
None.
run-smoke.ymlonly collectstests/consumer,tests/apiandtests/provider, so this suite runs only when invoked explicitly:pytest tests/accessibility -m accessibility -n 0