Repository navigation
test(seo): keep dev noindex tests out of the prod gate - #193
Merged
Merged
Conversation
In the prod gate HOME_URL_DEV points at prod, so as readonly tests they asserted noindex on prod and failed the 2026-10-09 frontend release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 2026-10-09 prod release (DataSpaceFrontend run 37926239517, #500) failed api-smoke on
test_dev_sends_noindex_headerandtest_dev_sitemap_is_disabled, and its rollback is waiting for approval.Cause: both tests sat in
test_api_006, which isreadonlyfor the whole file, and had nosmokemark. So only the prod gate ever selected them, and thereHOME_URL_DEVis set tohttps://civicdataspace.in. Theirdeployed_pr("DataSpaceFrontend#493", site="HOME_URL_DEV")gate kept them skipped until this release brought #493 to prod. Then they asserted noindex on prod, which is correctly indexable.Fix: move them to
test_api_027_dev_noindex.py, markedapi, smoke, seoand notreadonly.tests/api -m readonly --collect-only(prod gate)tests/api -m smoke --collect-only(dev gate)-m readonlyas the prod gate runs itThe other failure in that run,
test_search_reports_a_source_platform_bucket, was a timing issue: the backend's prod deploy (DataSpaceBackend run 37922161417) was rolling out at the same time, and prod search now returnssource_platform. No change needed for it.