Skip to content

test(seo): keep dev noindex tests out of the prod gate - #193

Merged
saqibmanan merged 2 commits into
CIfrom
fix/dev-noindex-off-prod-gate
Oct 9, 2026
Merged

saqibmanan merged 2 commits into
CIfrom
fix/dev-noindex-off-prod-gate

Conversation

@saqibmanan

Copy link
Copy Markdown
Contributor

The 2026-10-09 prod release (DataSpaceFrontend run 37926239517, #500) failed api-smoke on test_dev_sends_noindex_header and test_dev_sitemap_is_disabled, and its rollback is waiting for approval.

Cause: both tests sat in test_api_006, which is readonly for the whole file, and had no smoke mark. So only the prod gate ever selected them, and there HOME_URL_DEV is set to https://civicdataspace.in. Their deployed_pr("DataSpaceFrontend#493", site="HOME_URL_DEV") gate kept them skipped until this release brought #493 to prod. Then they asserted noindex on prod, which is correctly indexable.

Fix: move them to test_api_027_dev_noindex.py, marked api, smoke, seo and not readonly.

Check Result
tests/api -m readonly --collect-only (prod gate) 0 dev tests selected
tests/api -m smoke --collect-only (dev gate) both selected
027 vs dev 2 passed
027 with HOME_URL_DEV=prod 2 failed (still detects an indexable site)
006 -m readonly as the prod gate runs it 6 passed (prod backend cross-checks skip locally without API_BASE_URL_PROD)

The other failure in that run, test_search_reports_a_source_platform_bucket, was a timing issue: the backend's prod deploy (DataSpaceBackend run 37922161417) was rolling out at the same time, and prod search now returns source_platform. No change needed for it.

In the prod gate HOME_URL_DEV points at prod, so as readonly tests they
asserted noindex on prod and failed the 2026-10-09 frontend release.
@saqibmanan
saqibmanan merged commit af4f436 into CI Oct 9, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant