Skip to content

fix(api): stop returning exception text from metadata export #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anantjain341 merged 1 commit into from
Oct 12, 2026
Merged

fix(api): stop returning exception text from metadata export #245

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions api/views/metadata_export.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,18 @@ def metadata_export(request: HttpRequest, dataset_id: uuid.UUID) -> HttpResponse

standard = (request.GET.get("standard") or "dcat").strip().lower()
fmt = (request.GET.get("format") or "jsonld").strip().lower()
# Only these two inputs are the caller's fault. Fixed messages: never echo
# an exception to a public client.
options = export_options()
if standard not in options:
return JsonResponse({"error": "Unknown standard", "options": options}, status=400)
if fmt not in options[standard]["formats"]:
return JsonResponse(
{"error": "Format not available for this standard", "options": options}, status=400
)
try:
body, content_type, ext, report = export_dataset(dataset, standard, fmt)
except ValueError as exc:
return JsonResponse({"error": str(exc), "options": export_options()}, status=400)
except Exception as exc: # pragma: no cover - defensive; never 500 on a public page
except Exception as exc: # internal failure: log it, return a fixed message
logger.error(
"metadata_export_failed", dataset_id=str(dataset_id), standard=standard, error=str(exc)
)
Expand Down
Loading