Skip to content

Team-to-alumni: ignore photo-only deletes, remove stray Mihika image - #387

Merged
saqibmanan merged 2 commits into
mainfrom
fix/team-to-alumni-photo-only
Oct 7, 2026
Merged

saqibmanan merged 2 commits into
mainfrom
fix/team-to-alumni-photo-only

Conversation

@saqibmanan

Copy link
Copy Markdown
Contributor

Fixes #386

Problem

team-to-alumni.yml treated any deleted file under content/team/<slug>/ as that member leaving. Swapping Mihika's photo deleted the old image, so the workflow opened #368, which added content/alumnus/mihika/mihika.jpg with no profile. She is still on the team.

Changes

  • The workflow now acts only when content/team/<slug>/index.md is deleted. A real removal still copies every deleted file in that folder, photo included.
  • Removed the stray content/alumnus/mihika/mihika.jpg. It is the only file in that folder, and nothing references it.

Verified

The workflow's run: script was run in a throwaway git repo for old vs new, with git push / gh pr create stubbed:

commit old new
delete only team/mihika/mihika.jpg alumni PR for mihika, adds alumnus/mihika/mihika.jpg "No team members deleted"
delete whole team/aakash/ moves index.md + photo same
both in one commit moves aakash and mihika moves aakash only

#368 added content/alumnus/mihika/mihika.jpg with no profile after her photo
was swapped; she is still on the team.
Deleting just a photo from the CMS media library was treated as the member
leaving and opened an alumni PR for them (#368).
@saqibmanan
saqibmanan merged commit 6966dc9 into main Oct 7, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Team-to-alumni action fires on photo-only deletes

1 participant