Repository navigation
Team-to-alumni: ignore photo-only deletes, remove stray Mihika image - #387
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #386
Problem
team-to-alumni.ymltreated any deleted file undercontent/team/<slug>/as that member leaving. Swapping Mihika's photo deleted the old image, so the workflow opened #368, which addedcontent/alumnus/mihika/mihika.jpgwith no profile. She is still on the team.Changes
content/team/<slug>/index.mdis deleted. A real removal still copies every deleted file in that folder, photo included.content/alumnus/mihika/mihika.jpg. It is the only file in that folder, and nothing references it.Verified
The workflow's
run:script was run in a throwaway git repo for old vs new, withgit push/gh pr createstubbed:team/mihika/mihika.jpgalumnus/mihika/mihika.jpgteam/aakash/index.md+ photo