Repository navigation
CMS: link button for Solution, Summary and sector/event Description - #391
Merged
Merged
Conversation
Switch the 7 Work Solution fields from the plain text widget to the markdown widget, matching the Context fields (#388). The project page already renders Solution as Markdown, so no template change is needed.
Project and event pages printed Summary as plain text, so a link typed in it showed as [text](url). Render it with MarkdownView like Context and Solution, keep the existing spacing, and switch the 12 Summary fields in the CMS to the markdown widget with the link button.
Switch the sector and event category Description to MarkdownView and the CMS markdown widget with a link button. Links inside it override the sidebar's 200px block link style so they stay inline in the sentence.
saqibmanan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #388 (Context). Editors can now add hyperlinks with the CMS link button in these fields:
project.jsalready rendered it as Markdown.project.js/eventdetail.jsnow render it withMarkdownView.sector.js/event.jsrender it withMarkdownView. Links override the sidebar's 200px blockastyle so they stay inline.Every field uses the same restricted markdown widget as Context: bold, italic, link and lists. Team/Alumni Description is unchanged because it's split on
;and Bio already has a markdown editor.Verified locally:
gatsby buildpasses (125 pages). Existing Summary and Description text renders the same as before, with the same spacing. With a link injected at 1440px, the sector sidebar link is inline and 18px in the sidebar cyan, and the summary link is inline in the Context link teal.