Repository navigation
HEX-16: support Duel Commander Forge AI practice - #23
Merged
Merged
Conversation
Co-authored-by: multica-agent <github@multica.ai>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Co-authored-by: multica-agent <github@multica.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable native Forge AI practice for two-player Duel Commander BO1, with independent decks and one or two commanders. Both server and player hosting check explicit Duel AI support. Existing deck policies, hidden-zone projections, difficulty presets and model-opponent scope are preserved.
Cluster agents negotiate support using an optional registration response before sending extended report or placement fields. With a legacy strict coordinator, ordinary reporting and room creation remain available while unsupported Duel AI is disabled. Requirements are rejected rather than dropped. Frozen public-baseline agent, remote client, HTTP decoder and coordinator fixtures cover both mixed directions, both hosting requirements, new-to-new placement, registration replacement and strict validation.
Validation: the repair passes cluster/server Go vet, focused race tests, the complete cluster race suite and shared quality gates. The real hub welcome/create path against the frozen old coordinator preserves ordinary room creation and rejects unsupported Duel AI. Earlier unaffected evidence is retained: Qt creation/waiting-room/readout/WebSocket/protocol checks; all-tier native commander payment/tax regressions; naturally completed server-hosted single-commander and player-hosted partner games with reconnect, rematch, restart, concession and cleanup; maximized Linux Qt creation, independent deck selection, progression and leave. Windows/macOS and Qt 6.5 were not exercised; final native GUI evidence uses Linux XCB after a Wayland window-exposure prerequisite failure.
The earlier 674-test static suite initially had two failures: printing provenance was corrected and its four focused tests pass; the remaining feedback-workflow action-pin assertion also fails on unchanged base
7f6ee48ebdefb15ef64e949e3d22720ba0022842. That unrelated workflow/test is unchanged, and the full suite was not repeated for the cluster repair. No deployment changes are included.Fixes #22