Skip to content

HEX-34: add bilingual in-match keyword reference - #32

Merged
ClayStan404 merged 5 commits into
masterfrom
agent/hexproof-codex-sol/dff0f228b814
Nov 1, 2026
Merged

ClayStan404 merged 5 commits into
masterfrom
agent/hexproof-codex-sol/dff0f228b814

Conversation

@ClayStan404

@ClayStan404 ClayStan404 commented Oct 27, 2026 •

Copy link
Copy Markdown
Owner

Players can open a searchable, read-only keyword reference from the manual table action rail or Forge Settings without selecting a card or leaving the match. English and Chinese lookup, original explanations, rule references, empty/reset states, scrolling, modal input isolation and focus restoration are included.

The catalog covers all 70 keyword-action and 194 keyword-ability headings in the official Comprehensive Rules effective 2026-09-25. Versioned heading checks, update instructions and notices document variants, exclusions, unofficial Chinese lookup labels and the Assemble exception. The feature adds no gameplay protocol, persistent match state, automatic enforcement or dependency.

Review repairs clarify that Modular uses the actual counter count immediately before leaving the battlefield, and that Cumulative Upkeep, Fading, Suspend and Vanishing trigger at the beginning of your upkeep. All eight English/Chinese upkeep summaries are corrected; Fading and Vanishing retain their different sacrifice conditions.

Validation:

  • Fixed-source audit passed: fresh official download matches SHA-256 8d860e451f20f38865b725b42d82feb714c725373dd8f3b32b8652b3eeb070ca; all 264 headings match. Manually checked CR 702.24a/32a/62a/63a-b for the timing correction. Structural comparison confirms exactly eight summary fields changed in the latest repair and preserves the Modular correction.
  • python3 -m unittest discover -s tools/tests -p test_keyword_reference.py: 5 passed. Incremental hexproof_qml_test build and ctest --test-dir build/client-qt -R '^qml_keywordreference$' --output-on-failure --parallel 1: passed; 12 Qt cases, no failures/skips/warnings. Complete candidate git diff --check: passed.
  • Reused applicable earlier client/static checks and seven related QML suites. Existing manual/Forge native evidence covers 21 steps per mode at maximized 1920×1011 on a 1920×1080 display, DPR 1. Search, long text, scrolling, empty/reset states, Escape/button close and focus passed, with zero new commands, failed commands, error/snapshot changes or QML warnings. Latest repair changes catalog text only.
  • Required verification succeeded for the current head: run 41325939890. Scope/static jobs passed; application jobs were intentionally skipped.
  • Native evidence uses production Qt windows/input with isolated projection/profile fixtures. Windows, Qt 6.5, live Forge-engine matches, OS input injection and release qualification remain unverified. Broad suites and GUI runs were not repeated for this text correction.

Frozen candidate: base 6a0918974abd6b3652b92629b531f80dbca940a4, head d91712d627f554dce51a97cd134afbd5366b280c, tree cdc860aebd59fef732db41e69867c60fe435790f. SHA-256 of git diff --binary --full-index <base> <head> --: 0f5610f349bf8e0655aa5cf7ac4d5da6e3c4b4a881325b799649460978758412.

Independent AI review approved the complete final candidate and closing set [31] after confirming both content repairs. Integration requires current required checks and an expected-head guard.

Fixes #31

ClayStan404 and others added 3 commits October 27, 2026 01:46
@ClayStan404
ClayStan404 marked this pull request as ready for review November 1, 2026 12:54
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-11-01T16:21:46.475915Z
We couldn’t complete this review. Comment @codex review to try again.
d91712d New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f5685bc055

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

ClayStan404 and others added 2 commits November 1, 2026 11:00
Co-authored-by: multica-agent <github@multica.ai>
Co-authored-by: multica-agent <github@multica.ai>
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@ClayStan404
ClayStan404 merged commit 1cb9b9d into master Nov 1, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[建议] 能不能在对战界面增加一个方便玩家查询所有卡牌关键词效果的功能。

1 participant