Repository navigation
HEX-34: add bilingual in-match keyword reference - #32
Conversation
Co-authored-by: multica-agent <github@multica.ai>
…x-sol/dff0f228b814
Co-authored-by: multica-agent <github@multica.ai>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f5685bc055
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-authored-by: multica-agent <github@multica.ai>
Co-authored-by: multica-agent <github@multica.ai>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Players can open a searchable, read-only keyword reference from the manual table action rail or Forge Settings without selecting a card or leaving the match. English and Chinese lookup, original explanations, rule references, empty/reset states, scrolling, modal input isolation and focus restoration are included.
The catalog covers all 70 keyword-action and 194 keyword-ability headings in the official Comprehensive Rules effective 2026-09-25. Versioned heading checks, update instructions and notices document variants, exclusions, unofficial Chinese lookup labels and the Assemble exception. The feature adds no gameplay protocol, persistent match state, automatic enforcement or dependency.
Review repairs clarify that Modular uses the actual counter count immediately before leaving the battlefield, and that Cumulative Upkeep, Fading, Suspend and Vanishing trigger at the beginning of your upkeep. All eight English/Chinese upkeep summaries are corrected; Fading and Vanishing retain their different sacrifice conditions.
Validation:
8d860e451f20f38865b725b42d82feb714c725373dd8f3b32b8652b3eeb070ca; all 264 headings match. Manually checked CR 702.24a/32a/62a/63a-b for the timing correction. Structural comparison confirms exactly eight summary fields changed in the latest repair and preserves the Modular correction.python3 -m unittest discover -s tools/tests -p test_keyword_reference.py: 5 passed. Incrementalhexproof_qml_testbuild andctest --test-dir build/client-qt -R '^qml_keywordreference$' --output-on-failure --parallel 1: passed; 12 Qt cases, no failures/skips/warnings. Complete candidategit diff --check: passed.Frozen candidate: base
6a0918974abd6b3652b92629b531f80dbca940a4, headd91712d627f554dce51a97cd134afbd5366b280c, treecdc860aebd59fef732db41e69867c60fe435790f. SHA-256 ofgit diff --binary --full-index <base> <head> --:0f5610f349bf8e0655aa5cf7ac4d5da6e3c4b4a881325b799649460978758412.Independent AI review approved the complete final candidate and closing set [31] after confirming both content repairs. Integration requires current required checks and an expected-head guard.
Fixes #31