Repository navigation
deploy: keep complete Forge sources off game nodes - #35
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First home-node installations now verify the complete Forge runtime/source pair on the workstation and store only the matching source filename and SHA-256 in the node bundle. Complete sources stay centrally retained and available through the existing release/source distribution process.
Ordinary upgrades accept legacy bundles, verify the baseline and its candidate copy, and omit only the matching source archive from the new sealed tree. The original release remains available for rollback. Post-install checks compare mandatory normalized source identities across both formats, and reject missing, malformed or conflicting metadata.
Validation:
python3 -m unittest discover -s tools/tests -p 'test_home_*.py': 58 passed.python3 -m unittest discover -s tools/tests -p 'test_deploy_script.py': 78 passed.python3 tools/check-license-headers.py: passed.git diff --check: passed.Scope: deployment packaging and documentation. Existing live nodes migrate on their next requested upgrade; this change performs no live-node cleanup or restart.
Independent Astra review: APPROVE, no blocking findings, for base
c0c5ee506e5f45cf8015ef3a554800770ba74d9aand headdee210fd0545bc0af22241758e1886b7430ef12c. Canonical binary/full-index diff SHA-256:c0e863501bae900aeee77e64ee0da1540581026ecb4daf8e3e56c59bd018e750.