Skip to content

Property ordering in JSON: net10.0, MSTest 4.3.3, converter Read() fix #2156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vladimir-pecanac-main wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Property ordering in JSON: net10.0, MSTest 4.3.3, converter Read() fix #2156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions json-csharp/OrderPropertyJsonInCSharp/Benchmark/Benchmark.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net7.0</TargetFramework>
<TargetFramework>net10.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<OutputType>Exe</OutputType>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="BenchmarkDotNet" Version="0.13.5" />
<PackageReference Include="BenchmarkDotNet" Version="0.15.8" />
</ItemGroup>

<ItemGroup>
Expand Down
3 changes: 2 additions & 1 deletion ...yJsonInCSharp/OrderPropertyJsonInCSharp/Converters/MicrosoftOrderedPropertiesConverter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@ public override bool CanConvert(Type typeToConvert)

public override T Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
{
return JsonSerializer.Deserialize<T>(ref reader, options);
throw new NotSupportedException(
"This converter only controls the order properties are written in. Deserialize without it.");
}

public override void Write(Utf8JsonWriter writer, T value, JsonSerializerOptions options)
Expand Down
2 changes: 1 addition & 1 deletion json-csharp/OrderPropertyJsonInCSharp/OrderPropertyJsonInCSharp/Models/Student.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
{
public class Student: Person
{
public int RegistratioNumber { get; set; }
public int RegistrationNumber { get; set; }

public double Grade { get; set; }
}
Expand Down
4 changes: 2 additions & 2 deletions ...harp/OrderPropertyJsonInCSharp/OrderPropertyJsonInCSharp/OrderPropertyJsonInCSharp.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net7.0</TargetFramework>
<TargetFramework>net10.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
<PackageReference Include="Newtonsoft.Json" Version="13.0.4" />
</ItemGroup>

</Project>
10 changes: 10 additions & 0 deletions json-csharp/OrderPropertyJsonInCSharp/Tests/OrderPropertyJsonUnitTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,5 +69,15 @@ public void WhenUsingMicrosoftTypeInfoResolver_ThenReturnOrderedProperties()

Assert.AreEqual(expectedResult, json);
}

[TestMethod]
public void WhenDeserializingWithOrderedPropertiesConverter_ThenThrowsNotSupportedException()
{
var options = new System.Text.Json.JsonSerializerOptions();
options.Converters.Add(new MicrosoftOrderedPropertiesConverter<Animal>());

Assert.ThrowsExactly<NotSupportedException>(
() => System.Text.Json.JsonSerializer.Deserialize<Animal>("{\"Id\":1,\"Name\":\"Miau\",\"Age\":3}", options));
}
}
}
10 changes: 5 additions & 5 deletions json-csharp/OrderPropertyJsonInCSharp/Tests/Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net7.0</TargetFramework>
<TargetFramework>net10.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>

<IsPackable>false</IsPackable>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.3.2" />
<PackageReference Include="MSTest.TestAdapter" Version="2.2.10" />
<PackageReference Include="MSTest.TestFramework" Version="2.2.10" />
<PackageReference Include="coverlet.collector" Version="3.1.2" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.9.0" />
<PackageReference Include="MSTest.TestAdapter" Version="4.3.3" />
<PackageReference Include="MSTest.TestFramework" Version="4.3.3" />
<PackageReference Include="coverlet.collector" Version="10.0.1" />
</ItemGroup>

<ItemGroup>
Expand Down
Loading