Skip to content

Parsing DateTime in C#: retarget net10.0 and fix the misused format constant #2157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vladimir-pecanac-main wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Parsing DateTime in C#: retarget net10.0 and fix the misused format constant #2157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .../ParsingDateTimeInCSharp/ParsingDateTimeInCSharp.Test/ParsingDateTimeInCSharp.Test.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,21 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net7.0</TargetFramework>
<TargetFramework>net10.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>

<IsPackable>false</IsPackable>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.3.2" />
<PackageReference Include="xunit" Version="2.4.2" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.4.5">
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.9.0" />
<PackageReference Include="xunit" Version="2.9.3" />
<PackageReference Include="xunit.runner.visualstudio" Version="4.0.0">
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
<PackageReference Include="coverlet.collector" Version="3.1.2">
<PackageReference Include="coverlet.collector" Version="10.0.1">
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
Expand Down
79 changes: 39 additions & 40 deletions dotnet-datetime/ParsingDateTimeInCSharp/ParsingDateTimeInCSharp/ParseExactMethod.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,56 +1,55 @@
using System.Globalization;

namespace ParsingDateTimeInCSharp
namespace ParsingDateTimeInCSharp;

public static class ParseExactMethod
{
public static class ParseExactMethod
{
public static DateTime ParseExactWithStringAndStringAndFormatProviderInputParameters(string dateString, string format, string culture)
=> DateTime.ParseExact(dateString, format, new CultureInfo(culture));
public static DateTime ParseExactWithStringAndStringAndFormatProviderInputParameters(string dateString, string format, string culture)
=> DateTime.ParseExact(dateString, format, new CultureInfo(culture));

public static DateTime ParseExactWithStringAndStringAndFormatProviderAndDateTimeStylesInputParameters(string dateString, string format, string culture, DateTimeStyles dateTimeStyles)
=> DateTime.ParseExact(dateString, format, new CultureInfo(culture), dateTimeStyles);
public static DateTime ParseExactWithStringAndStringAndFormatProviderAndDateTimeStylesInputParameters(string dateString, string format, string culture, DateTimeStyles dateTimeStyles)
=> DateTime.ParseExact(dateString, format, new CultureInfo(culture), dateTimeStyles);

public static DateTime ParseExactWithSpanAndSpanAndFormatProviderAndDateTimeStylesInputParameters(string dateString, string format, string culture, DateTimeStyles dateTimeStyles)
=> DateTime.ParseExact(dateString.AsSpan(), format.AsSpan(), new CultureInfo(culture), dateTimeStyles);
public static Dictionary<string, DateTime> ParseExactWithStringAndStringArrayAndFormatProviderAndDateTimeStylesInputParameters(Dictionary<string,string> dateStrings, string[] formats, CultureInfo cultureInfo, DateTimeStyles dateTimeStyles)
{
var result = new Dictionary<string, DateTime>();
public static DateTime ParseExactWithSpanAndSpanAndFormatProviderAndDateTimeStylesInputParameters(string dateString, string format, string culture, DateTimeStyles dateTimeStyles)
=> DateTime.ParseExact(dateString.AsSpan(), format.AsSpan(), new CultureInfo(culture), dateTimeStyles);

public static Dictionary<string, DateTime> ParseExactWithStringAndStringArrayAndFormatProviderAndDateTimeStylesInputParameters(Dictionary<string,string> dateStrings, string[] formats, CultureInfo cultureInfo, DateTimeStyles dateTimeStyles)
{
var result = new Dictionary<string, DateTime>();

try
{
foreach (string format in formats)
{
var dateString = dateStrings[format];
result.Add(dateString, DateTime.ParseExact(dateString, formats, cultureInfo, dateTimeStyles));
}
}
catch (FormatException ex)
try
{
foreach (string format in formats)
{
Console.WriteLine(ex.Message);
var dateString = dateStrings[format];
result.Add(dateString, DateTime.ParseExact(dateString, formats, cultureInfo, dateTimeStyles));
}

return result;
}

public static Dictionary<string, DateTime> ParseExactWithSpanAndStringArrayAndFormatProviderAndDateTimeStylesInputParameters(Dictionary<string, string> dateStrings, string[] formats, CultureInfo cultureInfo, DateTimeStyles dateTimeStyles)
catch (FormatException ex)
{
var result = new Dictionary<string, DateTime>();
Console.WriteLine(ex.Message);
}

try
{
foreach (string format in formats)
{
var dateString = dateStrings[format];
result.Add(dateString, DateTime.ParseExact(dateString.AsSpan(), formats, cultureInfo, dateTimeStyles));
}
}
catch (FormatException ex)
return result;
}

public static Dictionary<string, DateTime> ParseExactWithSpanAndStringArrayAndFormatProviderAndDateTimeStylesInputParameters(Dictionary<string, string> dateStrings, string[] formats, CultureInfo cultureInfo, DateTimeStyles dateTimeStyles)
{
var result = new Dictionary<string, DateTime>();

try
{
foreach (string format in formats)
{
Console.WriteLine(ex.Message);
var dateString = dateStrings[format];
result.Add(dateString, DateTime.ParseExact(dateString.AsSpan(), formats, cultureInfo, dateTimeStyles));
}

return result;
}
catch (FormatException ex)
{
Console.WriteLine(ex.Message);
}

return result;
}
}
27 changes: 13 additions & 14 deletions dotnet-datetime/ParsingDateTimeInCSharp/ParsingDateTimeInCSharp/ParseMethod.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,22 @@
using System.Globalization;

namespace ParsingDateTimeInCSharp
namespace ParsingDateTimeInCSharp;

public static class ParseMethod
{
public static class ParseMethod
{
public static DateTime ParseWithStringInputParameter(string dateString)
=> DateTime.Parse(dateString);
public static DateTime ParseWithStringInputParameter(string dateString)
=> DateTime.Parse(dateString);

public static DateTime ParseWithStringAndFormatProviderInputParameters(string dateString, string culture)
=> DateTime.Parse(dateString, new CultureInfo(culture));
public static DateTime ParseWithStringAndFormatProviderInputParameters(string dateString, string culture)
=> DateTime.Parse(dateString, new CultureInfo(culture));


public static DateTime ParseWithStringAndFormatProviderAndDateTimeStylesInputParameters(string dateString, string culture, DateTimeStyles dateTimeStyles)
=> DateTime.Parse(dateString, new CultureInfo(culture), dateTimeStyles);
public static DateTime ParseWithStringAndFormatProviderAndDateTimeStylesInputParameters(string dateString, string culture, DateTimeStyles dateTimeStyles)
=> DateTime.Parse(dateString, new CultureInfo(culture), dateTimeStyles);

public static DateTime ParseWithSpanAndFormatProviderInputParameters(string dateString, string culture)
=> DateTime.Parse(dateString.AsSpan(), new CultureInfo(culture));
public static DateTime ParseWithSpanAndFormatProviderInputParameters(string dateString, string culture)
=> DateTime.Parse(dateString.AsSpan(), new CultureInfo(culture));

public static DateTime ParseWithSpanAndFormatProviderAndDateTimeStylesInputParameters(string dateString, string culture, DateTimeStyles dateTimeStyles)
=> DateTime.Parse(dateString.AsSpan(), new CultureInfo(culture), dateTimeStyles);
}
public static DateTime ParseWithSpanAndFormatProviderAndDateTimeStylesInputParameters(string dateString, string culture, DateTimeStyles dateTimeStyles)
=> DateTime.Parse(dateString.AsSpan(), new CultureInfo(culture), dateTimeStyles);
}
2 changes: 1 addition & 1 deletion ...t-datetime/ParsingDateTimeInCSharp/ParsingDateTimeInCSharp/ParsingDateTimeInCSharp.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net7.0</TargetFramework>
<TargetFramework>net10.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
</PropertyGroup>
Expand Down
Loading
Loading