Bring solutions branch up to date - #1462
Open
abdishakoor-dev wants to merge 36 commits into
Open
Conversation
* Fix up typos in exercises * Update a bunch of week-1s to Sprint-1s * Use toEqual not toBe * Add a bit more scaffolding for exports and requires, as we currently don't reliably teach this. * Add a few more edge cases to test for * Move root package.json to Sprint-3 directory, because that's the set of tests it hard-codes as modules, and rework instructions to not assume you're installing stuff in the root of the repo. * Change refactor exercises from implementing `find` to implementing `includes` - because `find` returns the index, I would consider it better implemented with a for-with-index loop than a for..of loop. `includes` does not share this property.
* Add package-lock.json * Misc copy edits and typo fixes * Add extension to in-sprint querystring parsing
Thanks to @Grajales-K ! ⭐
* Update tests for Sprint 1 'fix median' task * Update tests for Sprint 1 'fix' exercise with median * Add tests to check for errors and mixed arrays (advanced implementation of median) * Update exercise file to provide hint for solution
Also changed the array in "doesn't modify the input array" to an unsorted array.
* Move Jest configuration to root of Sprint-3 directory - Allows using the Jest testing extension in VS Code or the terminal - Deduplicates repeated configuration * Move test dependencies to dev * Get workspaces from package file
Co-authored-by: Daniel Wagner-Hall <dawagner@gmail.com>
Co-authored-by: Daniel Wagner-Hall <dawagner@gmail.com>
Co-authored-by: Daniel Wagner-Hall <dawagner@gmail.com>
Co-authored-by: Daniel Wagner-Hall <dawagner@gmail.com>
Update todo-list to demonstrate testing with ESM
We inherit these from the org now
Remove PR template
Add mean and describe-median katas to implement, and change the existing fix/implement exercises to throw on bad input instead of ignoring it, matching the updated Sprint 1 prep.
Sync Sprint 1 exercises with the error-handling prep
The exercises that deal with invalid input still asked trainees to return false, or to skip values that weren't numbers. They now expect a named error instead, matching what the Sprint 1 prep teaches.
Make Sprint 2 exercises throw on bad input, matching the Sprint 1 prep
This comment has been minimized.
This comment has been minimized.
abdishakoor-dev
added
the
NotCoursework
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges main into solutions and updates the answers to match the current tests, which now throw on bad input. Adds solutions for mean, describe-median, querystring and mode.