Charter: Auto-generate strumlines if the JSON is missing - #1056
Merged
Conversation
shoutout that one dude in modding help who pointed out that cne crashes if you do something other than make a strumline immediately after loading into the charter
clairedeluneee
marked this pull request as draft
August 10, 2026 11:24
Contributor
Author
|
hi 7pm claire here with more mental clarity this time im actually gonna test this now if you dont mind |
Contributor
Author
|
ok it works but its crashing when i open the generated strumlines time to triage |
clairedeluneee
marked this pull request as ready for review
August 10, 2026 12:46
Contributor
Author
|
ok i think it works now |
clairedeluneee
changed the title
moxie-coder
approved these changes
Aug 10, 2026
clairedeluneee
changed the title
Contributor
Author
|
should have probably described what this does last week when i made the pr basically, the charter does not check if the chart json is missing (either it was deleted, moved, or just never existed in the case where the song was just created) which leads to the game crashing if you do anything other than make a strumline |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2 am pull request. Testing highly encouraged. Maintainers are free to edit if needed.
Will be going to bed as soon as I hit the create pull request button. Goodnight.