Add excludeList to FunkinParentDisabler - #1080
Open
THEkatinamicrowave wants to merge 9 commits into
Open
Conversation
something that should probably be there. Could also make ParentCancellable typedef that just encompasses FlxTween FlxCamera FlxTimer and FlxSound but I think Dynamic is fine for now
so that the compiler doesn't have to deal with Array<Dynamic> every time
…xcludeLists on an event basis
Raltyro
requested changes
Sep 7, 2026
MRK2009
reviewed
Sep 10, 2026
| var __restoreUponDestroy:Bool; | ||
| public function new(replaceUponDestroy:Bool = false, restoreUponDestroy:Bool = true) { | ||
|
|
||
| public function new(excludeList:Array<ParentDisableable> = [], replaceUponDestroy:Bool = false, restoreUponDestroy:Bool = true) { |
Contributor
There was a problem hiding this comment.
I think this includes for FunkinParentDisabler too, if I'm not mistaken.(Also sorry for the double notification, I pressed the wrong button.)
Contributor
Author
There was a problem hiding this comment.
What includes FunkinParentDisabler? ParentDisableable?
Contributor
Author
There was a problem hiding this comment.
I'm unsure what use case could rationalize putting FunkinParentDisabler in ParentDisableable, but if you can find one I can probably do that. For the record, ParentDisableable is a wrapper for FlxTween, FlxTimer, FlxCamera, and FlxSound, since I don't want to make the compiler deal with Dynamic.
Contributor
Author
|
holy I think I finally fixed every error it's actually building |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
something that should probably be there. Could also make
ParentDisableabletypedef that just encompasses<FlxTween, FlxCamera, FlxTimer, FlxSound>but I thinkDynamicis fine for now. Could break if somebody ever usedFunkinParentDisabler's first two constructor args but I think it's ok because I've never seen it used in mods (personally). If it does break too much stuff, can simply moveexcludeListto the end of the constructor args