fix thorns scripted cutscene softlock - #1098
Merged
Merged
Conversation
Member
|
it doesnt work anymore cus now its a static variable . so yes PlayState.SONG would be the way to access it |
Contributor
|
That thing worked because of a weird behavior performed in HScript that allows you to access static fields from an instance (workaround made for vanilla custom classes implementation) that has been disabled (and soon removed). |
Contributor
Author
I see, thanks for the insight, i was pretty confused at first why something like that would stop working all of a sudden. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Playstate.instance.SONG doesn't work anymore for some reason so it just locks up when loading the dialogue uh oh